sec (2/9): reject inline env values in user-defined scanners#26
Open
jesse-merhi wants to merge 1 commit into
Open
sec (2/9): reject inline env values in user-defined scanners#26jesse-merhi wants to merge 1 commit into
jesse-merhi wants to merge 1 commit into
Conversation
A user-defined scanner declares required env as bare variable names; the value is supplied by the environment. An inline value (API_TOKEN=secret) would leak into requirement diagnostics, the artifact env map, and the Docker sandbox passthrough. Reject any env entry that is not a bare, valid variable name. The validation error echoes only the name before "=", never the value.
This was referenced Jul 23, 2026
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: sec (2/9): reject inline env values in user-defined scanners This is item 1/1 in the current shard. Shard 0/1. This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
A user-defined scanner's
env:list must contain bare variable names(
API_TOKEN), never inlineNAME=valuepairs. An entry with an=is rejectedat config-resolution time, and — critically — the rejected value is never
echoed in the error.
Why it matters
env:exists so a scanner can be handed a secret that ClawScan reads from theprocess environment and records only by presence (
present/missing). If anauthor writes
API_TOKEN=sk-live-...inline, the secret would live in theconfig file and could surface in logs/errors. Requiring bare names keeps secret
values out of config entirely, matching the repo rule "record env presence,
never values."
Before / after (runnable)
env.yml:NAME=valueaccepted; secret value carried in configThe reject message names
API_TOKENbut does not containsk-live-secret.A bare
env: [API_TOKEN]is still accepted.Verify