fix: use shutil.move to handle cross-device file upload#281
Merged
Conversation
with [Errno 18] Invalid cross-device link when /tmp and the media directory are on different mount points (common in Docker environments). Replace with shutil.move() which gracefully falls back to copy+delete when moving across devices."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base repository：opendatalab/labelU，base：main
Problem
When running LabelU in Docker with
/tmpand the media directorymounted on different devices, uploading files fails with:
[Errno 18] Invalid cross-device link: '/tmp/tmpxxx' -> '/root/.local/share/labelu/media/upload/...'
Root Cause
LocalStorage.save_fileusesPath.replace()which callsos.rename()under the hood.
os.rename()cannot move files across different mountpoints or devices.
Fix
Replace
local_path.replace(target_path)withshutil.move(str(local_path), str(target_path)).shutil.move()gracefully falls back to copy+delete when movingacross devices, resolving the issue.
File Changed
labelu/internal/common/storage.py