Skip to content

fix: use shutil.move to handle cross-device file upload #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gary-Shen merged 1 commit into from
Jun 8, 2026
+2 −1
Merged

fix: use shutil.move to handle cross-device file upload #281

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion labelu/internal/common/storage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

from abc import ABC, abstractmethod
from functools import lru_cache
import shutil
from pathlib import Path
from typing import Optional

Expand Down Expand Up @@ -60,7 +61,7 @@ def _resolve(self, key: str) -> Path:
def save_file(self, local_path: Path, key: str, content_type: Optional[str] = None) -> None:
target_path = self._resolve(key)
target_path.parent.mkdir(parents=True, exist_ok=True)
local_path.replace(target_path)
shutil.move(str(local_path), str(target_path))

def save_bytes(self, content: bytes, key: str, content_type: Optional[str] = None) -> None:
target_path = self._resolve(key)
Expand Down