version release: fix finalize isLatest check#511
Open
gmarzot wants to merge 1 commit into
Open
Conversation
gh release view has no isLatest --json field (only gh release list does), so the Confirm release published step always exited 1 after the release was already live. Keep isPrerelease/name from release view and derive isLatest by comparing the tag against the releases/latest API, still without forcing --latest. Also tighten the stale finalize header comment. Port of openmoq/moxygen#331. Fixes #510
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #510. Port of openmoq/moxygen#331.
isLatestis not a supported--jsonfield ongh release view(only ongh release list), so the finalize job'sConfirm release publishedstep always exited 1 after the release was already live — seen on the v0.2.1 run (https://github.com/openmoq/moqx/actions/runs/30053012201), where the release published fine with all 4 assets.Changes:
isPrerelease/namefromgh release view; derive latest-ness by comparing$TAGagainstgh api repos/$REPO/releases/latest. Still no--latestforcing — GitHub's auto-latest algorithm stays authoritative.Tested locally against v0.2.1:
YAML validated. v0.2.1 itself needs no re-cut.
This change is