Skip to content

version release: fix finalize isLatest check #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gmarzot wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −3
Open

version release: fix finalize isLatest check #511

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions .github/workflows/version-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,8 +454,8 @@ jobs:
xargs -0 -n1 -P 6 -I{} gh release upload "$TAG" --repo "$REPO" {} --clobber

# ════════════════════════════════════════════════════════════════════════════
# Finalize: mark release as latest once all uploads succeeded.
# Tolerates portable-build being skipped (has_portable=false).
# Finalize: confirm the release is fully published once all uploads
# succeeded. Tolerates portable-build being skipped (has_portable=false).
# ════════════════════════════════════════════════════════════════════════════

finalize:
Expand Down Expand Up @@ -487,4 +487,8 @@ jobs:
# would mark a hotfix patch from a release/vM.m branch as
# latest even when a newer vM.(m+1) line exists.
echo "Released: $TAG"
gh release view "$TAG" --repo "$REPO" --json isLatest,isPrerelease,name --jq '"isLatest=\(.isLatest) isPrerelease=\(.isPrerelease) name=\(.name)"'
# isLatest is not a --json field on `gh release view` (only on
# `gh release list`), so derive it from the releases/latest API.
gh release view "$TAG" --repo "$REPO" --json isPrerelease,name --jq '"isPrerelease=\(.isPrerelease) name=\(.name)"'
LATEST=$(gh api "repos/$REPO/releases/latest" --jq .tag_name)
echo "isLatest=$([ "$LATEST" = "$TAG" ] && echo true || echo false) (latest=$LATEST)"
Loading