Skip to content

OCPBUGS-111096: Expose frrk8sConfig.secretPassthrough in MetalLB CR - #339

Merged
openshift-merge-bot[bot] merged 2 commits into
openshift:release-4.21from
oribon:secretpassthrough_4.21
Aug 19, 2026
Merged

OCPBUGS-111096: Expose frrk8sConfig.secretPassthrough in MetalLB CR#339
openshift-merge-bot[bot] merged 2 commits into
openshift:release-4.21from
oribon:secretpassthrough_4.21

Conversation

@oribon

@oribon oribon commented Aug 17, 2026

Copy link
Copy Markdown

semi-clean cherry-pick of #334
depends on openshift/metallb#297

oribon and others added 2 commits August 17, 2026 12:23
Allows passing BGP secret references to frr-k8s without resolving them
to cleartext. Requires frr-k8s external mode. The secret must exist in
the frr-k8s namespace in order for frr-k8s to read it.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Ori Braunshtein <obraunsh@redhat.com>
(cherry picked from commit 59e506e)
(cherry picked from commit 1469dd0)
Signed-off-by: Ori Braunshtein <obraunsh@redhat.com>
(cherry picked from commit dc49d00)
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 17, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@oribon: This pull request references Jira Issue OCPBUGS-98717, which is invalid:

  • expected the bug to target either version "4.21.z." or "openshift-4.21.z.", but it targets "4.22.z" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead
  • expected dependent Jira Issue OCPBUGS-88727 to target a version in 4.22.0, but it targets "5.0.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

semi-clean cherry-pick of #334
depends on openshift/metallb#297

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@oribon oribon changed the title OCPBUGS-98717: Expose frrk8sConfig.secretPassthrough in MetalLB CR OCPBUGS-111096: Expose frrk8sConfig.secretPassthrough in MetalLB CR Aug 17, 2026
@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: e6052e71-0cb6-4f01-920a-ea90d31a6d90

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Aug 17, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@oribon: This pull request references Jira Issue OCPBUGS-111096, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.z) matches configured target version for branch (4.21.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-98717 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-98717 targets the "4.22.z" version, which is one of the valid target versions: 4.22.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (gkopels@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

semi-clean cherry-pick of #334
depends on openshift/metallb#297

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Aug 17, 2026
@oribon

oribon commented Aug 17, 2026

Copy link
Copy Markdown
Author

/jira refresh

@openshift-ci-robot

Copy link
Copy Markdown

@oribon: This pull request references Jira Issue OCPBUGS-111096, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.z) matches configured target version for branch (4.21.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-98717 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-98717 targets the "4.22.z" version, which is one of the valid target versions: 4.22.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (gkopels@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
openshift-ci Bot requested review from dougbtv and fedepaol August 17, 2026 09:25
@openshift-ci

openshift-ci Bot commented Aug 17, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oribon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 17, 2026
@openshift-ci

openshift-ci Bot commented Aug 17, 2026

Copy link
Copy Markdown

@oribon: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@karampok

Copy link
Copy Markdown

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 18, 2026
@oribon

oribon commented Aug 19, 2026

Copy link
Copy Markdown
Author

/verified later @gkopels
/label backport-risk-assessed

@openshift-ci openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Aug 19, 2026
@openshift-ci-robot openshift-ci-robot added verified-later verified Signifies that the PR passed pre-merge verification criteria labels Aug 19, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@oribon: This PR has been marked to be verified later by @gkopels.

Details

In response to this:

/verified later @gkopels
/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot
openshift-merge-bot Bot merged commit 91bbbe9 into openshift:release-4.21 Aug 19, 2026
8 checks passed
@openshift-ci-robot

Copy link
Copy Markdown

@oribon: Jira Issue OCPBUGS-111096: All pull requests linked via external trackers have merged:

This pull request has the verified-later tag and will need to be manually moved to VERIFIED after testing. Jira Issue OCPBUGS-111096 has been moved to the MODIFIED state.

Details

In response to this:

semi-clean cherry-pick of #334
depends on openshift/metallb#297

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@oribon

oribon commented Aug 19, 2026

Copy link
Copy Markdown
Author

/cherry-pick release-4.20

@openshift-cherrypick-robot

Copy link
Copy Markdown

@oribon: new pull request created: #340

Details

In response to this:

/cherry-pick release-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria verified-later

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants