Skip to content

[release-4.20] OCPBUGS-111994: Expose frrk8sConfig.secretPassthrough in MetalLB CR - #340

Open
openshift-cherrypick-robot wants to merge 2 commits into
openshift:release-4.20from
openshift-cherrypick-robot:cherry-pick-339-to-release-4.20
Open

[release-4.20] OCPBUGS-111994: Expose frrk8sConfig.secretPassthrough in MetalLB CR#340
openshift-cherrypick-robot wants to merge 2 commits into
openshift:release-4.20from
openshift-cherrypick-robot:cherry-pick-339-to-release-4.20

Conversation

@openshift-cherrypick-robot

Copy link
Copy Markdown

This is an automated cherry-pick of #339

/assign oribon

oribon and others added 2 commits August 19, 2026 08:36
Allows passing BGP secret references to frr-k8s without resolving them
to cleartext. Requires frr-k8s external mode. The secret must exist in
the frr-k8s namespace in order for frr-k8s to read it.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Ori Braunshtein <obraunsh@redhat.com>
(cherry picked from commit 59e506e)
(cherry picked from commit 1469dd0)
Signed-off-by: Ori Braunshtein <obraunsh@redhat.com>
(cherry picked from commit dc49d00)
@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 9e7d63ab-2f74-4c90-801d-24bcea2cf1ea

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@openshift-ci-robot

Copy link
Copy Markdown

@openshift-cherrypick-robot: Jira Issue OCPBUGS-111096 has been cloned as Jira Issue OCPBUGS-111994. Will retitle bug to link to clone.
/retitle [release-4.20] OCPBUGS-111994: Expose frrk8sConfig.secretPassthrough in MetalLB CR

Details

In response to this:

This is an automated cherry-pick of #339

/assign oribon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot changed the title [release-4.20] OCPBUGS-111096: Expose frrk8sConfig.secretPassthrough in MetalLB CR [release-4.20] OCPBUGS-111994: Expose frrk8sConfig.secretPassthrough in MetalLB CR Aug 19, 2026
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 19, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-111994, which is invalid:

  • expected dependent Jira Issue OCPBUGS-111096 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #339

/assign oribon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
openshift-ci Bot requested review from dougbtv and oribon August 19, 2026 08:37
@oribon

oribon commented Aug 19, 2026

Copy link
Copy Markdown

/label backport-risk-assessed
/verified later @gkopels

@openshift-ci openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Aug 19, 2026
@oribon

oribon commented Aug 19, 2026

Copy link
Copy Markdown

/approve

@openshift-ci-robot openshift-ci-robot added verified-later verified Signifies that the PR passed pre-merge verification criteria labels Aug 19, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@oribon: This PR has been marked to be verified later by @gkopels.

Details

In response to this:

/label backport-risk-assessed
/verified later @gkopels

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Aug 19, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, oribon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2026
@openshift-ci

openshift-ci Bot commented Aug 19, 2026

Copy link
Copy Markdown

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. verified Signifies that the PR passed pre-merge verification criteria verified-later

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants