[CPU] The registers pool implementation for JIT kernels.#12880
Merged
maxnick merged 8 commits intoSep 29, 2022
Merged
Conversation
ceciliapeng2011
requested review from
chenhu-wang,
dmitry-gorokhov,
luo-cheng2021,
nshchego and
usstq
OleksiiZaderykhinCapgemini
force-pushed
the
jit_kernel_register_pool
branch
from
039b900 to
0dc8ba2
Compare
praasz
reviewed
Sep 5, 2022
|
Are there examples how RegisterPool is used during JIT kernel implementation? |
Contributor
Author
@dmitry-gorokhov, yes, currently I am preparing the PR with JIT kernel for Gather operation where this pool is used. |
OleksiiZaderykhinCapgemini
force-pushed
the
jit_kernel_register_pool
branch
2 times, most recently
from
a91392b to
1f09b1a
Compare
lohika-denis-kotov
changed the title
OleksiiZaderykhinCapgemini
force-pushed
the
jit_kernel_register_pool
branch
from
1f09b1a to
cdaa747
Compare
nshchego
approved these changes
Sep 22, 2022
maxnick
approved these changes
Sep 22, 2022
OleksiiZaderykhinCapgemini
force-pushed
the
jit_kernel_register_pool
branch
2 times, most recently
from
508324f to
0ae963e
Compare
Contributor
Author
|
Hi, @ceciliapeng2011, @nshchego, @maxnick. This PR has 3 approval already. Should I ping someone to initiate merging? |
Contributor
|
@dmitry-gorokhov, could you please take a look and merge this PR? |
Contributor
This PR is ready to merge. But, we need green CI do merge it. |
OleksiiZaderykhinCapgemini
force-pushed
the
jit_kernel_register_pool
branch
4 times, most recently
from
6a04a7d to
6d3b649
Compare
…egisters while developing jit kernels.
…for different ISA and different Xbyak register types.
…ch exclude some critical registers by default.
…ert. The std::is_base_of and Xbyak::Mmx was used to identify vector registers. The factory method was added for RegistersPool with isa non template parameter.
OleksiiZaderykhinCapgemini
force-pushed
the
jit_kernel_register_pool
branch
from
6d3b649 to
b242cb5
Compare
Contributor
Author
|
Hi, @dmitry-gorokhov, @ceciliapeng2011, and @maxnick this PR has green CI and 3 approvals. Could someone merge it, please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The RegistersPool class was implemented. It is helpful for managing registers while developing jit kernels.
This is done as the first part of the Gather JIT kernel improvement to cover all execution cases.