✨ OPRUN-4514: Move Single Own Namespace support back to alpha#2568
✨ OPRUN-4514: Move Single Own Namespace support back to alpha#2568openshift-merge-bot[bot] merged 1 commit intooperator-framework:mainfrom
Conversation
Signed-off-by: Todd Short <tshort@redhat.com>
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
This PR moves SingleOwnNamespaceInstallSupport back to alpha (disabled by default) and scopes the ClusterExtension.spec.config field back to experimental CRD generation, effectively reverting the GA promotion from #2428.
Changes:
- Set
SingleOwnNamespaceInstallSupportto Alpha and Default=false, and update e2e defaults accordingly. - Remove
spec.configfrom standard CRDs (including helm standard CRD), while keeping it available in experimental CRDs and marking it experimental in Go types / API docs. - Update manifests, Helm/Tilt configs, docs, and demo scripts to reflect the alpha/experimental gating.
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| test/e2e/steps/hooks.go | Default feature gate map updated to reflect alpha/off behavior for Single/Own namespace installs. |
| manifests/standard.yaml | Removes spec.config from the standard ClusterExtension CRD schema. |
| manifests/standard-e2e.yaml | Removes spec.config from the standard-e2e ClusterExtension CRD schema. |
| manifests/experimental.yaml | Ensures experimental deployment args enable SingleOwnNamespaceInstallSupport. |
| manifests/experimental-e2e.yaml | Ensures experimental-e2e deployment args enable SingleOwnNamespaceInstallSupport. |
| internal/operator-controller/features/features.go | Moves Single/Own namespace support back to Alpha and disables by default. |
| helm/tilt.yaml | Enables SingleOwnNamespaceInstallSupport in Tilt dev configuration. |
| helm/olmv1/base/operator-controller/crd/standard/olm.operatorframework.io_clusterextensions.yaml | Removes spec.config from the standard helm CRD. |
| helm/experimental.yaml | Enables SingleOwnNamespaceInstallSupport in experimental helm values. |
| hack/demo/single-namespace-demo-script.sh | Switches demos to experimental CRDs and patches feature gate on; cleanup logic updated (but currently broken). |
| hack/demo/own-namespace-demo-script.sh | Switches demos to experimental CRDs and patches feature gate on; cleanup logic updated (but currently broken). |
| docs/tutorials/explore-available-content.md | Adds note about needing the feature gate for Single/Own namespace targeting. |
| docs/draft/tutorials/explore-available-content-metas-endpoint.md | Same note added to the draft tutorial. |
| docs/draft/howto/single-ownnamespace-install.md | Updates guidance to explicitly enable the alpha feature gate and adds enablement steps. |
| docs/api-reference/olmv1-api-reference.md | Marks spec.config as experimental in the API reference output. |
| applyconfigurations/api/v1/clusterextensionspec.go | Marks Config field as experimental in applyconfiguration comments. |
| api/v1/clusterextension_types.go | Marks Config field as experimental in API type comments. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
|
|
||
| # restore standard CRDs | ||
| echo "Restoring standard CRDs..." | ||
| kubectl apply -f "$(dirname "${BASH_SOURCE[0]}")/../../manifests/base.yaml" |
|
|
||
| !!! note | ||
| The `SingleOwnNamespaceInstallSupport` feature-gate is enabled by default. Use this guide to configure bundles that need Single or Own namespace install modes. | ||
| This feature is still in *alpha* the `SingleOwnNamespaceInstallSupport` feature-gate must be enabled to make use of it. |
| echo "Removing feature gate from operator-controller..." | ||
| kubectl patch deployment -n olmv1-system operator-controller-controller-manager --type='json' -p='[{"op": "remove", "path": "/spec/template/spec/containers/0/args", "value": "--feature-gates=SingleOwnNamespaceInstallSupport=true"}]' || true |
|
|
||
| # restore standard CRDs | ||
| echo "Restoring standard CRDs..." | ||
| kubectl apply -f "$(dirname "${BASH_SOURCE[0]}")/../../manifests/base.yaml" |
| # remove feature gate from deployment | ||
| echo "Removing feature gate from operator-controller..." | ||
| kubectl patch deployment -n olmv1-system operator-controller-controller-manager --type='json' -p='[{"op": "remove", "path": "/spec/template/spec/containers/0/args", "value": "--feature-gates=SingleOwnNamespaceInstallSupport=true"}]' || true |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: grokspawn The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
e7a9611
into
operator-framework:main
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2568 +/- ##
==========================================
- Coverage 68.64% 68.61% -0.04%
==========================================
Files 131 131
Lines 9333 9333
==========================================
- Hits 6407 6404 -3
- Misses 2433 2438 +5
+ Partials 493 491 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Effectively reverts #2428
Description
Reviewer Checklist