fix(buck2): export consumer TypeScript runner - #1339
Merged
schickling merged 8 commits intoSep 22, 2026
Merged
Conversation
agent-identity: dev3.direct.omp.mqs8cse3 agent-persona: generalist agent-supervisor: unavailable agent-tool: OMP agent-tool-version: 18.2.6 agent-runtime: OMP 18.2.6 agent-model: openai-codex/gpt-5.6-sol tooling-profile: dotfiles@965ef7e-dirty
agent-identity: dev3.direct.omp.mqs8cse3 agent-persona: generalist agent-supervisor: unavailable agent-tool: OMP agent-tool-version: 18.2.6 agent-runtime: OMP 18.2.6 agent-model: openai-codex/gpt-5.6-sol tooling-profile: dotfiles@965ef7e-dirty
schickling-assistant
marked this pull request as ready for review
September 22, 2026 09:51
schickling
enabled auto-merge (squash)
September 22, 2026 10:44
agent-identity: dev3.direct.omp.mqs8cse3 agent-persona: generalist agent-supervisor: unavailable agent-tool: OMP agent-tool-version: 18.2.6 agent-runtime: OMP 18.2.6 agent-model: openai-codex/gpt-5.6-sol tooling-profile: dotfiles@965ef7e-dirty
agent-identity: dev3.direct.omp.mqs8cse3 agent-persona: generalist agent-supervisor: unavailable agent-tool: OMP agent-tool-version: 18.2.6 agent-runtime: OMP 18.2.6 agent-model: openai-codex/gpt-5.6-sol tooling-profile: dotfiles@965ef7e-dirty
agent-identity: dev3.direct.omp.mqs8cse3 agent-persona: generalist agent-supervisor: unavailable agent-tool: OMP agent-tool-version: 18.2.6 agent-runtime: OMP 18.2.6 agent-model: openai-codex/gpt-5.6-sol tooling-profile: dotfiles@965ef7e-dirty
agent-identity: dev3.direct.omp.mqs8cse3 agent-persona: generalist agent-supervisor: unavailable agent-tool: OMP agent-tool-version: 18.2.6 agent-runtime: OMP 18.2.6 agent-model: openai-codex/gpt-5.6-sol tooling-profile: dotfiles@965ef7e-dirty
agent-identity: dev3.direct.omp.mqs8cse3 agent-persona: generalist agent-supervisor: unavailable agent-tool: OMP agent-tool-version: 18.2.6 agent-runtime: OMP 18.2.6 agent-model: openai-codex/gpt-5.6-sol tooling-profile: dotfiles@965ef7e-dirty
agent-identity: dev3.direct.omp.mqs8cse3 agent-persona: generalist agent-supervisor: unavailable agent-tool: OMP agent-tool-version: 18.2.6 agent-runtime: OMP 18.2.6 agent-model: openai-codex/gpt-5.6-sol tooling-profile: dotfiles@965ef7e-dirty
schickling
deleted the
schickling-assistant/2026-09-20-p2-rules-product
branch
September 22, 2026 20:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The standalone Buck rules artifact copied the provider workspace's root
BUCKfile even though that file referenced targets and packages that the artifact intentionally omits. The artifact also did not own the root targets expected bymkConsumerBuckRoot. A standalone consumer therefore failed while analyzing the configured TypeScript toolchain withpackage .../buck2-tools does not exist.Goal
Give the distributed rules artifact a self-contained root package that exposes only its declared runtime surface.
Decisions
BUCKpackage during the Nix build.package_tree_runtime,package_command_runtime, and the nested TypeScript runner export in that package.BUCKfile into the artifact.Verification
BUCKpackage.buck2 cquery fixture//buck2/toolchains:effect_tsgosucceeds.buck2 uqueryresolvesrules//:package_tree_runtime,rules//:package_command_runtime, andrules//:packages/@overeng/buck2-tools/src/typescript-runner.ts.git diff --checkpasses.Pre-flip deviations
devenv tasks run check:quick --no-tuiremains queued behind the shared heavy-build admission outage tracked in schickling/dotfiles#2984. The focused replay above exercises the exact analysis failure and the final artifact contract.Complexity
Low. The distributed artifact now owns a three-target root package instead of importing an unrelated workspace root.
Concerns
None.
Friction & bottlenecks
The shared heavy-build admission lock is held beyond its runtime cap. That outage prevents the repository-wide gate from starting.
Follow-ups
None.
References
Posted on behalf of @schickling
agent_identitysessionagent_personaagent_supervisoragent_toolagent_tool_versionagent_runtimeagent_modelworktreetooling_profile