REF: Use moments accumulator from libalgos to compute variance#64848
Closed
Alvaro-Kothe wants to merge 4 commits into
Closed
REF: Use moments accumulator from libalgos to compute variance#64848Alvaro-Kothe wants to merge 4 commits into
libalgos to compute variance#64848Alvaro-Kothe wants to merge 4 commits into
Conversation
Member
Member
Author
libalgos and fix float computationlibalgos and fix complex variance computation
98703da to
0a569f9
Compare
libalgos and fix complex variance computationlibalgos
libalgoslibalgos to compute variance
0a569f9 to
3b74275
Compare
3b74275 to
23b6f0f
Compare
23b6f0f to
e857f81
Compare
Member
|
@Alvaro-Kothe is this worth spending more time reviewing, or is it superceded by the SIMD PR? |
Member
Author
This isn't superseded by the SIMD PR (#64905). But I think it's best to put this on a hold for now, because the SIMD code can be used for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.AGENTS.md.Use the moments accumulator functions introduced in #64366 to compute variance, standard error and standard error of the mean.
Not applying these changes to
nanvarbecause had a big performance impact on several cases, mainly for integer types.Benchmarks
Details