Fix SIT classic parser miscounting folder markers as files#1
Merged
Conversation
Folder start (0x20) and folder end (0x21) markers were incorrectly incrementing the `done` counter in parse_classic(), causing the iteration loop to terminate early when archives contained folders. The SIT spec (sit.md § 4.7) explicitly states: "Folder markers do not contribute to file_count." The file_count field only counts actual file entries, not structural folder markers. This caused archives like SSW_7.0-800k.sit.Hqx (which wraps a single file inside a folder) to extract zero files: the folder-start marker consumed the entire file_count budget of 1, and the loop exited before reaching the actual file entry. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Folder start (0x20) and folder end (0x21) markers were incorrectly incrementing the
donecounter in parse_classic(), causing the iteration loop to terminate early when archives contained folders.The SIT spec (sit.md § 4.7) explicitly states: "Folder markers do not contribute to file_count." The file_count field only counts actual file entries, not structural folder markers.
This caused archives like to extract zero files: the folder-start marker consumed the entire file_count budget of 1, and the loop exited before reaching the actual file entry.