Skip to content

Fix SIT classic parser miscounting folder markers as files #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pappadf merged 1 commit into from
Apr 9, 2026
Merged

Fix SIT classic parser miscounting folder markers as files #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/formats/sit.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -602,6 +602,7 @@ static bool parse_classic(const uint8_t *blob, size_t blob_len,
uint8_t dm = hdr[1];

// sit.md § 4.4 — folder start marker (0x20)
// Folder markers do NOT count toward file_count (sit.md § 4.7).
if (rm == SIT_FOLDER_START || dm == SIT_FOLDER_START) {
uint8_t nlen = hdr[2];
if (depth < SIT_MAX_DEPTH && nlen < 64) {
Expand All @@ -610,15 +611,14 @@ static bool parse_classic(const uint8_t *blob, size_t blob_len,
depth++;
}
cursor += SIT_ENTRY_HDR_SIZE;
done++;
continue;
}

// sit.md § 4.4 — folder end marker (0x21)
// Folder markers do NOT count toward file_count (sit.md § 4.7).
if (rm == SIT_FOLDER_END || dm == SIT_FOLDER_END) {
if (depth > 0) depth--;
cursor += SIT_ENTRY_HDR_SIZE;
done++;
continue;
}

Expand Down
Loading