Update skill - #85
Open
jcgueriaud1 wants to merge 7 commits into
Open
Conversation
Merged
3 tasks
jcgueriaud1
added a commit
that referenced
this pull request
Jul 7, 2026
…ction hook, doc fixes (#111) * Broaden vaadin-playwright-test skill trigger to indirect requests The skill matcher keys off signals present in the conversation. When a requirement lives inside a fetched issue/PR/spec body (e.g. "Implement #85.") rather than the user's own words, none of the old trigger keywords appear in the prompt and the skill never fires. Widen the description to trigger on indirect requests, on in-context code signals (SpringPlaywrightIT, @PlaywrightElement, IT file paths), and any Vaadin-project task involving a Playwright/IT test. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * Fix skill docs: hallucinated APIs, mangled examples, autonomous-mode steps - element-mapping.md: verify every method in the Key Methods column against the auto-generated api-reference.md; replace non-existent APIs (selectByText, clickRow, sortByColumn, assertUnchecked, sendMessage, uploadFile, wrong get(page) factories) with the real ones - SKILL.md: fix wrong wrapper calls in the raw-locator guidance, restore the formatter-mangled Java templates, document MainView/Main root route mapping, add a version-drift caveat for api-reference.md, and make Steps 4-5 write/run without confirmation during autonomous execution - setup.md: clean up malformed XML snippets - TESTING.md: describe page objects by library package instead of a source path that only exists in the DramaFinder repo Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * Make the skill trigger on dependency detection, not just prompt wording Skill matching is a heuristic over context: a task that never mentions Vaadin/Playwright/tests gives the model no signal to load the skill. Add two deterministic signal sources: - SessionStart plugin hook that greps pom.xml for the dramafinder artifact and, on a hit, injects a standing reminder to use the skill for any IT test work - setup.md step that appends an equivalent pointer to the consuming project's CLAUDE.md, covering sessions where the plugin hook isn't active Bump plugin version to 0.3.0 (plugin.json + tile.json). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.