[ENG-3568] Point login at the approval page, not the API root - #150
Merged
Conversation
|
Login now directs users to the device approval page with clear single-click confirmation. 🎯 Quality: 84% Excellent · 📦 Size: Extra Large — strongly consider breaking this down 🛡️ Standards: no pre-flight fit check ran for this change — wire 📈 This month: Your 56th PR — above team average · Averaging Excellent |
`login` printed {apiOrigin}/activate. That origin is the API, not the
dashboard, and /activate already serves the team-seat "set a password" page —
so following the link landed on an unrelated screen with nothing to approve.
Points at monitor/pulse/device instead, which redirects to the dashboard SPA,
and carries the code in the query so following the link is a single
confirmation rather than retyping it.
Co-Authored-By: Claude <noreply@anthropic.com>
mariojgt
force-pushed
the
mariot/eng-3568-pulse-auth
branch
from
August 19, 2026 14:30
0a8bb16 to
a9a688e
Compare
Contributor
Author
|
/review |
patchstackdave
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pairs with patchstack/saas#1335, which adds the page this points at.
The bug
loginprinted:api.patchstack.comis the API origin, not the dashboard — and/activatealready serves the team-seat "set a password" page. Following the link landed on an unrelated screen with nothing to approve, so the flow could not be completed.The fix
The API redirects that to the dashboard SPA — the CLI only knows the API origin, and the page lives on the app. The code travels in the query, so following the link is a single confirmation rather than retyping it.
Works from a logged-out browser too: the dashboard stores the full path through sign-in and returns to it with the code intact.
Verification
1213 tests pass, typecheck clean. The existing
logintest now asserts the redirect URL rather than the old one.Merge after saas#1335 — until that deploys, the redirect target does not exist.
Ref ENG-3568
🤖 Generated with Claude Code