Skip to content

[ENG-3568] Point login at the approval page, not the API root #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mariojgt merged 1 commit into from
Aug 20, 2026
Merged

[ENG-3568] Point login at the approval page, not the API root #150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/login.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,10 @@ export async function login(
interval: number;
};

const verificationUri = `${new URL(base).origin}/activate`;
// Points at the API, which redirects to the dashboard SPA — the CLI only
// knows the API origin, and the approval page lives on the app. The code
// travels in the link so following it is a single confirmation.
const verificationUri = `${base}/device?code=${encodeURIComponent(userCode)}`;
onPrompt(userCode, verificationUri);

const deadline = now() + expiresIn * 1000;
Expand Down
7 changes: 6 additions & 1 deletion tests/login.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,12 @@ describe('login', () => {
const result = await login(config(), onPrompt, { fetchImpl: fetchImpl as never, ...noSleep });

expect(result.status).toBe('approved');
expect(onPrompt).toHaveBeenCalledWith('WDJB-MJHT', 'https://api.patchstack.com/activate');
// The API redirects this to the dashboard SPA; the code rides along so
// following the link is one confirmation rather than a retype.
expect(onPrompt).toHaveBeenCalledWith(
'WDJB-MJHT',
'https://api.patchstack.com/monitor/pulse/device?code=WDJB-MJHT',
);

// Both fields: approving rotates the one secret block-logs use too, so
// leaving apiKey behind would break block-log reporting.
Expand Down
Loading