feat(contacts): contact list redesign [PERA-3929] [PERA-4123]#374
Merged
yasin-ce merged 6 commits intocontacts/03-shared-domainfrom Apr 25, 2026
Merged
feat(contacts): contact list redesign [PERA-3929] [PERA-4123]#374yasin-ce merged 6 commits intocontacts/03-shared-domainfrom
yasin-ce merged 6 commits intocontacts/03-shared-domainfrom
Conversation
- Redesigned ContactListScreen: empty-state CTA, populated list with name + truncated address, per-row QR button, search with no-match state. Plus icon lives in the navigation header via useNavigationHeader (only when contacts exist). - ContactQRBottomSheet (new): QR code scaled with screen width, truncated + full address, copy/share actions. Accessible label on the QR wrapper. - Removed ContactListHeaderButtons — inlined via useNavigationHeader. - Route no longer binds headerRight to the deleted component. - vitest: mock react-native-share so the QR sheet's shareText util can be exercised in tests. - i18n: contacts.list.qr_sheet_copy, qr_sheet_share, qr_accessibility_label.
5 tasks
yasin-ce
requested review from
fmsouza and
wjbeau
and removed request for
wjbeau
Collaborator
Author
|
wjbeau
requested changes
Apr 24, 2026
…mitives per review - Extract ContactListScreen logic into a colocated useContactListScreen hook with an explicit result type (search state, QR state, memoized filter, navigation callbacks). - Replace the bespoke empty state with EmptyView. - Swap raw FlatList for PWFlatList. - Use EmptyView for the no-match state inside ListEmptyComponent. - useCallback renderItem / keyExtractor / row handlers so they stay stable across renders. - useCallback handleCopy and handleShare in ContactQRBottomSheet.
wjbeau
approved these changes
Apr 25, 2026
| <PWText variant='h3'>{title}</PWText> | ||
| <PWText style={styles.message}>{message}</PWText> | ||
| <PWText | ||
| variant='body' |
Contributor
There was a problem hiding this comment.
technically unnecessary - body is the default
yasin-ce
added a commit
that referenced
this pull request
Apr 27, 2026
- EditContactScreen.tsx: collapse merge artifact (duplicate useStyles
imports, duplicate selectedContact/save declarations, stray useEffect
referencing undefined symbols) into the clean useEditContactForm-based
version.
- ContactListScreen.tsx: drop c.id ?? c.address (Contact no longer has
an id field after the address-as-PK refactor); use c.address directly.
- ContactQRBottomSheet.spec.tsx: drop id from the test fixture.
- PWInput: expose rightIconContainerStyle, autoComplete, selectTextOnFocus,
and align onFocus/onBlur with RNEInputProps so SearchInput can pass them
through without a TS suppression.
- SearchInput: type SearchInputProps from PWInputProps instead of the
wider InputProps so the {...props} spread is type-compatible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Checklist
Additional Notes
Stacked on #373. `ContactListScreen.spec.tsx` updated for the redesign; `ContactQRBottomSheet.spec.tsx` added.