feat(contacts): view contact page [PERA-4122]#375
Merged
yasin-ce merged 5 commits intocontacts/04-listfrom Apr 25, 2026
Merged
Conversation
- Redesigned ViewContactScreen: avatar, name + short address, full address with copy, QR trigger, NFD label when resolved. - Share + edit buttons live in the navigation header via useNavigationHeader. - Reuses ContactQRBottomSheet for the QR modal. - Removed ViewContactHeaderButtons component + route headerRight wiring. - i18n: contacts.view_contact.account_address.
5 tasks
yasin-ce
requested review from
fmsouza,
wjbeau and
yasincaliskan
and removed request for
wjbeau
Collaborator
Author
|
wjbeau
approved these changes
Apr 24, 2026
…play per review - Extract ViewContactScreen logic into useViewContactScreen hook with explicit result type (selectedContact, NFD lookup, QR visibility, share/edit handlers). - Replace CopyableText + PWText composition with AddressDisplay (addressFormat='full', displayType='address-only', showCopy=false). - Use PWTouchableIcon for header share/edit and the inline QR icon so they get proper hit areas and feedback. - Remove redundant style comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Checklist
Additional Notes
Stacked on #374. `ViewContactScreen.spec.tsx` expanded from 1 → 8 tests: rendering, empty view, NFD resolution, QR sheet open, share success, edit navigation, share-rejection swallowing.