feat(contacts): edit contact page + shared confirm dialog [PERA-3931] [PERA-3988]#376
Merged
yasin-ce merged 5 commits intocontacts/05-viewfrom Apr 24, 2026
Merged
feat(contacts): edit contact page + shared confirm dialog [PERA-3931] [PERA-3988]#376yasin-ce merged 5 commits intocontacts/05-viewfrom
yasin-ce merged 5 commits intocontacts/05-viewfrom
Conversation
… [PERA-3988]
- Redesigned EditContactScreen: delete pill, Done in header via
useNavigationHeader, ConfirmActionBottomSheet (trash icon, red
accent) for the delete flow (fixes PERA-3988 — old dialog used
light-theme styling in dark mode). Uses shared useEditContactForm.
- ContactForm: drop the transitional namePlaceholder /
isAddressEditable props now that all callers are migrated.
- Multisig EditParticipantScreen: drop namePlaceholder prop (collateral).
- Settings: DeleteAllConfirmBottomSheet migrated to the shared
ConfirmActionBottomSheet; old component + hook deleted.
- ViewContactScreen: top margin on NFDomain section for visual separation.
- i18n: prune orphaned edit_contact.{delete_confirm, delete, save,
are_you_sure}; add {done, delete_this, remove_*}.
Note: the AddContact route still points at EditContactScreen until PR 7
(add contact page) lands.
5 tasks
yasin-ce
requested review from
AshishAnshoo,
fmsouza,
wjbeau and
yasincaliskan
and removed request for
AshishAnshoo and
fmsouza
Collaborator
Author
|
<img width="1080" height="2400" alt="Screenshot |
wjbeau
approved these changes
Apr 24, 2026
… per review Screen now renders the permission-denied sheet from useEditContactForm's exposed permissionDenied state, so the refactored useImagePicker flow (no more Alert.alert) surfaces correctly when a user has permanently denied photo-library access.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Checklist
Additional Notes
Stacked on #375. `EditContactScreen.spec.tsx` and `useSettingsScreen.test.ts` updated for the migration.