feat(contacts): add contact page + form polish [PERA-3930]#377
Merged
yasin-ce merged 5 commits intocontacts/06-editfrom Apr 24, 2026
Merged
feat(contacts): add contact page + form polish [PERA-3930]#377yasin-ce merged 5 commits intocontacts/06-editfrom
yasin-ce merged 5 commits intocontacts/06-editfrom
Conversation
- New AddContactScreen with photo picker, NFD resolution, and footer
submit button. Wires the AddContact route to the new screen (was
pointing at EditContactScreen).
- ContactForm: drop multiline on the address input — aligns cursor +
scan icon vertically, matches AddressEntryField's single-line
convention. Add left margin to the scan icon so long addresses
don't butt up against it.
- PWInput: widen default padding from spacing.xs to spacing.md
horizontally — text was flush to the edge in every input.
- SearchInput: replace iOS-only clearButtonMode with a cross-platform
PWTouchableIcon X button; switch leading glass icon to primary
variant for dark-mode legibility.
- Theme: dark-mode linkPrimary → yellow (matches brand palette, was
turquoise which didn't match the rest of the dark-mode yellow
accents like the edit-avatar badge).
- AddParticipantBottomSheet: set explicit cross icon size for
consistency.
- i18n: contacts.edit_contact.add_contact ("Add contact" submit
label).
5 tasks
yasin-ce
requested review from
fmsouza and
wjbeau
and removed request for
wjbeau
wjbeau
approved these changes
Apr 24, 2026
… clear per review - Render PhotoPermissionDeniedSheet in AddContactScreen so the refactored useImagePicker surfaces the permission-denied bottom sheet at the screen root. - Restore SearchInput to native iOS clearButtonMode='while-editing' rather than the cross-platform PWTouchableIcon X; keep the magnifying-glass at variant='secondary' for the lighter gray. - Drop borderBottomWidth: 0 from PWInput/styles.ts — verified 0 is the effective default and the override was unnecessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Checklist
Additional Notes
Top of stack — stacked on #376. `AddContactScreen.spec.tsx` added; `SearchInput.spec.tsx` expanded (1 → 3 tests) for the clear-button behavior. Full mobile suite green at this commit: 2236 passing / 1 skipped.