Fix to correctly handle date-times when timezone Id is provided#111
Open
chamakura wants to merge 1 commit into
Open
Fix to correctly handle date-times when timezone Id is provided#111chamakura wants to merge 1 commit into
chamakura wants to merge 1 commit into
Conversation
Owner
|
This adds a library to ical.js. Because it's intended that ical.js can be used in a browser without a build step, this won't work - would it be possible to extract the necessary logic from moment-tz? |
Author
|
I see - let me look into adding this without the library dependency. |
Author
|
So it looks like one option is to inline the dataset corresponding to all available timezones: https://github.com/moment/moment-timezone/blob/develop/builds/moment-timezone-with-data-10-year-range.js#L693 Or is there a way to dynamically link to dynamically link to https://momentjs.com/downloads/moment-timezone-with-data-10-year-range.min.js? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like the parsing logic to extract date-times isn't handling timezones correctly. The way it's correctly implemented, it's assumed that the provided timestamp value is in UTC even when a corresponding timezone value is provided. This change factors in the timezone (when available) to correctly convert the value in UTC. (This is to handle #3 in https://www.kanzaki.com/docs/ical/dateTime.html)
This issue manifested in MagicMirror where events scheduled by someone in a different timezone were getting offset. For example, if someone in New York (timezone=America/New_York) sent me (I'm in timezone=America/Los_Angeles) an invite, the event would show up 3 hours later than expected because that's the difference between the timezones.