refactor: code cleanup — named constants, dedup, naming consistency, XML docs - #27
Merged
Merged
Conversation
…XML docs - CardTypeDetector: extract BinRanges nested class with 10 named constants for all BIN/IIN prefix ranges (MasterCard, Discover, JCB, Diners Club) - PasswordStrengthAnalyzer: extract TimeConstants nested class (SecondsPerMinute through SecondsPerMillennium) replacing magic literals in EstimateCrackTime() - PasswordGenerator: add MinPasswordLength=8 / MaxPasswordLength=128 constants - MergeService: add NoteHashSnippetLength=256 constant; extract MergeCollection<T>() generic helper — eliminates 4 identical merge loops (~44 duplicated lines) - Add Helpers/ListViewHelpers.cs with ShowSavedToast(TeachingTip, Action?) centralising identical toast boilerplate from 4 list-view code-behind files - Rename _res → _resourceLoader in all 9 view files for naming clarity - DashboardViewModel: add XML <summary> documentation to all 18 ObservableProperty declarations (greeting, stat cards, weekly activity, health, search) Build: 0 errors, 0 warnings. Tests: 176/176 pass. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CardTypeDetector(BIN ranges),PasswordStrengthAnalyzer(time conversions),PasswordGenerator(length bounds),MergeService(note snippet size)MergeCollection<T>()helper (~44 duplicated lines removed)Helpers/ListViewHelpers.cswithShowSavedToast(TeachingTip, Action?)centralising identical toast boilerplate from 4 list-view code-behind files_res→_resourceLoaderin all 9 view files/// <summary>added to all 18[ObservableProperty]declarations inDashboardViewModelTest plan
dotnet build PassKey.sln -p:Platform=x64— 0 errors, 0 warningsdotnet test— 176/176 pass🤖 Generated with Claude Code