fix(cli): platform-specific keychain store hints after login (#235)#265
Open
adriannoes wants to merge 2 commits into
Open
fix(cli): platform-specific keychain store hints after login (#235)#265adriannoes wants to merge 2 commits into
adriannoes wants to merge 2 commits into
Conversation
gbrlcustodio
reviewed
Jun 2, 2026
gbrlcustodio
reviewed
Jun 2, 2026
gbrlcustodio
reviewed
Jun 2, 2026
gbrlcustodio
previously approved these changes
Jun 2, 2026
gbrlcustodio
left a comment
gbrlcustodio
left a comment
Member
There was a problem hiding this comment.
Inline notes are all non-blocking; nothing here blocks merge.
Branch error messages on macOS, Linux, and Windows when OAuth succeeds but store_session fails. Document the macOS errSecParam (-25244) ACL workaround in docs/cli/auth.md.
Qualify the macOS ACL note for uvx path churn, tighten platform hint tests with required/forbidden fragments, and rename the helper to _auth_keychain_hints.py. Align the MCP README with the same diagnosis.
adriannoes
force-pushed
the
fix/cli-macos-keychain-hint-235
branch
from
July 13, 2026 17:34
40fe31b to
ec94d8d
Compare
Collaborator
Author
|
@gbrlcustodio — thanks again for the earlier approval and the non-blocking notes. I missed the review comments at the time; just caught up and addressed them after rebasing onto current
Also confirmed the change is still needed on CI is green after the rebase. Could you take another look when you have a moment? Happy to adjust anything. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
auth_keychain_hints.pywith platform-specific remediation text whenpipefy auth loginsucceeds at OAuth butstore_sessionfails.errSecParam (-25244)and the Terminal.app + Always Allow ACL workaround instead of the headless Linux Secret Service hint.PIPEFY_KEYCHAIN_BACKEND=filehint and add a Windows Credential Manager variant.docs/cli/auth.md.Closes #235.