Skip to content

docs: fix pipefy-login AUTH_URL note and document local-checkout plugin testing#399

Merged
mocha06 merged 2 commits into
devfrom
docs/auth-login-url-and-keychain-note
Jul 14, 2026
Merged

docs: fix pipefy-login AUTH_URL note and document local-checkout plugin testing#399
mocha06 merged 2 commits into
devfrom
docs/auth-login-url-and-keychain-note

Conversation

@mocha06

@mocha06 mocha06 commented Jul 13, 2026

Copy link
Copy Markdown
Collaborator

What

Two documentation changes.

1. /pipefy:pipefy-login command — drop the false PIPEFY_AUTH_URL requirement

commands/pipefy-login.md claimed PIPEFY_AUTH_URL must be set in the shell. It isn't required — it defaults to the prod OIDC issuer (https://signin.pipefy.com/realms/pipefy). Only non-prod IdPs need it. Reworded to say so.

2. Document testing the plugin from a local checkout

Adds a README section on pointing the plugin marketplace at a local clone (so a working branch loads live), including the /reload-plugins step and the extraKnownMarketplaces lock gotcha. Linked from CONTRIBUTING's skill quick-start so contributors can try skills before opening a PR.

Dropped from this PR

An earlier revision also rewrote the macOS keychain troubleshooting entry in docs/cli/auth.md. That's been removed — #265 already owns that section (with CLI code, and closes #235), so the keychain guidance is deferred there to avoid a competing narrative. See the review thread for the -25244 constant details.

Scope

Docs and command text only. No code or behavior changes.

@mocha06
mocha06 force-pushed the docs/auth-login-url-and-keychain-note branch from f633d5c to 92e149b Compare July 13, 2026 19:32
@mocha06 mocha06 changed the title docs(auth): correct PIPEFY_AUTH_URL requirement and macOS keychain cause docs: fix auth login/keychain guidance and document local-checkout plugin testing Jul 13, 2026

@adriannoes adriannoes left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

Static review of the docs-only changes (checkout not required; CI lint/test are green). The PIPEFY_AUTH_URL fix in commands/pipefy-login.md matches the prod default in code. The keychain troubleshooting rewrite in docs/cli/auth.md needs a correction before merge: it equates -25244 with missing Security.framework entitlements, which does not match Apple's SecBase mapping.

What worked well

  • Dropping the false PIPEFY_AUTH_URL requirement and documenting the prod issuer default.
  • Replacing "is rare" with concrete remediations (PIPEFY_KEYCHAIN_BACKEND=file, system/Homebrew Python).
  • The local Claude Code marketplace checkout section is useful for contributors.

Required before merge

  • F1: Rewrite the macOS keychain sentence so -25244 is not described as missing entitlements (see inline).

Also noted

  • Open PR #265 edits the same troubleshooting section with a different narrative; reconcile when the second of these lands. Updating packages/mcp/README.md can stay with that follow-up.

Verification

  • Confirm DEFAULT_AUTH_URL remains https://signin.pipefy.com/realms/pipefy.
  • Confirm the auth.md paragraph no longer ties -25244 to missing entitlements.

Comment thread docs/cli/auth.md Outdated
The /pipefy:pipefy-login command claimed PIPEFY_AUTH_URL must be set in the
shell, but it defaults to the prod OIDC issuer
(https://signin.pipefy.com/realms/pipefy). Only non-prod IdPs need to set it.
Reword the note to say so.
Add a README section explaining how to point the plugin marketplace at a
local clone (so a working branch loads live), including the /reload-plugins
step and the gotcha where an extraKnownMarketplaces entry locks the GitHub
marketplace. Link it from CONTRIBUTING's skill quick-start so contributors
try skills before opening a PR.
@mocha06
mocha06 force-pushed the docs/auth-login-url-and-keychain-note branch from 92e149b to b586c6e Compare July 13, 2026 20:01
@mocha06 mocha06 changed the title docs: fix auth login/keychain guidance and document local-checkout plugin testing docs: fix pipefy-login AUTH_URL note and document local-checkout plugin testing Jul 13, 2026

@adriannoes adriannoes left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

Re-checked the latest head (b586c6ed). The contested docs/cli/auth.md keychain rewrite is gone, so F1 is addressed by dropping that hunk and deferring the narrative to #265. What remains is the accurate PIPEFY_AUTH_URL default note in commands/pipefy-login.md plus the local Claude Code marketplace checkout docs.

What worked well

  • Confirming the SecBase mapping in-thread and choosing handoff to #265 instead of shipping a competing keychain story.
  • Keeping the AUTH_URL fix and the contributor local-checkout guidance.

Verification

  • Diff no longer touches docs/cli/auth.md.
  • CI lint/test green on the current head.

@mocha06
mocha06 merged commit cf24e9d into dev Jul 14, 2026
2 checks passed
@gbrlcustodio
gbrlcustodio deleted the docs/auth-login-url-and-keychain-note branch July 15, 2026 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants