feat(app): hide direct install and uninstall when bootloader is locked - #29
Merged
Conversation
pixincreate
changed the title
pixincreate
changed the title
pixincreate
force-pushed
the
feat/locked-bootloader-guard
branch
from
June 1, 2026 11:35
98329e5 to
1ffe51b
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds bootloader lock-state detection and uses it to hide risky Magisk operations (direct flashing, inactive-slot flashing, uninstall) when the device bootloader is locked, across both the legacy (Fragments/XML) and new Compose UI.
Changes:
- Introduces
Info.isBootloaderLockedbased on system properties (ro.boot.vbmeta.device_state, fallbackro.boot.flash.locked). - Hides Direct Install and Install to Inactive Slot when bootloader is locked (legacy + Compose).
- Hides Uninstall when bootloader is locked (legacy + Compose).
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| app/core/src/main/java/com/topjohnwu/magisk/core/Info.kt | Adds bootloader lock-state detection used by UIs/viewmodels. |
| app/apk/src/main/res/layout/fragment_install_md2.xml | Hides “Direct Install” method on locked bootloaders in legacy UI. |
| app/apk/src/main/res/layout/fragment_home_md2.xml | Hides legacy uninstall button on locked bootloaders. |
| app/apk/src/main/java/com/topjohnwu/magisk/ui/install/InstallViewModel.kt | Propagates lock-state into legacy install flow logic (noSecondSlot). |
| app/apk-ng/src/main/java/com/topjohnwu/magisk/ui/install/InstallViewModel.kt | Propagates lock-state into Compose install flow logic (noSecondSlot). |
| app/apk-ng/src/main/java/com/topjohnwu/magisk/ui/install/InstallBottomSheet.kt | Hides Compose “Direct Install” entry when bootloader is locked. |
| app/apk-ng/src/main/java/com/topjohnwu/magisk/ui/home/HomeScreen.kt | Hides Compose uninstall button when bootloader is locked. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pixincreate
marked this pull request as ready for review
June 1, 2026 17:26
pixincreate
force-pushed
the
master
branch
2 times, most recently
from
July 13, 2026 14:56
1fb02cc to
6bbb994
Compare
github-actions
Bot
force-pushed
the
master
branch
2 times, most recently
from
August 4, 2026 08:00
b859b9d to
c601cd4
Compare
pixincreate
force-pushed
the
master
branch
3 times, most recently
from
August 13, 2026 07:44
065ca99 to
d03451e
Compare
On devices with locked bootloaders and integrated Magisk root (e.g. GrapheneOS with Magisk), direct install to boot partition and uninstall operations present a softbrick risk. Only allow patching a file (which the user handles externally) in such environments. - Add isBootloaderLocked detection via ro.boot.vbmeta.device_state - apk-ng: Hide Direct Install and Install to Inactive Slot when locked - apk-ng: Hide Uninstall button when locked - apk (legacy): Same changes for the older UI
…uards, fix spacer - Cache isBootloaderLocked as eager val with case-insensitive comparison - Add hard guard in install() for locked-incompatible methods - Sanitize methodId on state restore in legacy ViewModel - Fix spacer visibility gap when bootloader locked + env active
pixincreate
force-pushed
the
feat/locked-bootloader-guard
branch
from
August 14, 2026 10:46
7b95874 to
575fa8a
Compare
pixincreate
added a commit
that referenced
this pull request
Aug 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #28
Detect bootloader lock state via system properties (
ro.boot.vbmeta.device_state) and restrict risky operations:Still available: Select and Patch a File, Download and Patch a File, install options (keep_verity, keep_enc, recovery_mode) — these produce a patched image file that the user handles externally.
Changes apply to both the new Compose UI (
apk-ng) and the legacy Fragment UI (apk).