Initial implementation of ACME Renewal Information#897
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Implements initial support for ACME Renewal Information to decide earlier renewal of certificates and updates target framework.
- Adds GetRenewalCertificates activity to incorporate ACME renewal suggestion window logic.
- Introduces X509Certificate2Extensions.GetCertificateId for querying RenewalInfo.
- Updates logging and target framework/net version alongside submodule bump.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| KeyVault.Acmebot.csproj | Bumps target framework to net9.0 to use newer platform features. |
| Internal/X509Certificate2Extensions.cs | Adds helper to build ACME certificate ID. |
| Functions/SharedActivity.cs | Replaces expiring-certificate logic with renewal-aware logic. |
| Functions/RenewCertificates.cs | Adjusts orchestrator to use new renewal activity and improves (partially) logging. |
| ACMESharpCore | Updates submodule to newer commit (likely enabling Renewal Info API support). |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #739
Close #846