Closed
Conversation
Collaborator
Author
|
I've decided to focus on SQLAlchemy, which gives us all the features we want for all the databases we care about, as far as I can tell. Now you can do this: from sqlalchemy import create_engine
querychat_config = querychat.init(
SQLAlchemySource(
create_engine(f"sqlite:///{Path(__file__).parent / 'titanic.sqlite3'}"),
"titanic",
),
greeting=greeting,
data_description=data_desc,
)This may simplify further in the future so you only need to pass the connection string and not call @blairj09 See https://docs.snowflake.com/en/developer-guide/python-connector/sqlalchemy for doing this with Snowflake. |
Collaborator
Author
|
We've moved development to |
This was referenced Jun 3, 2025
Contributor
|
closing since #20 is merged |
cpsievert
added a commit
that referenced
this pull request
Dec 18, 2025
Apply text improvements across R and Python documentation: - Reframe data privacy language: emphasize we're NOT sending raw data to LLM for complex math operations - Soften tone around auto-generated greetings: describe as "downsides" rather than "slow, wasteful, and non-deterministic" - Remove duplicate "under the hood" phrasing - Add local model example (gpt-oss:20b) - Use friendlier duckdb function in R (duckdb_read_csv) Addresses unresolved feedback items #2, #4, #5, #7, #10 from PR #162 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not merge this PR. Already accounted for in #19, #20 via c6a24a7
Close this PR when #20 is merged.
This PR is intended to make querychat extensible beyond in-memory Pandas dataframes, including but not limited to:
It introduces a protocol called
DataSource, which so far has two concrete implementations:DataFrameSourceandSQLiteSource.TODO