Fix white seam at chat-bubble tail junction in app icon#926
Merged
Conversation
bubbleClip (the clip-path gating the glass-highlight overlay in icon-source.svg / icon-source-maskable.svg) used a stale tail coordinate (y=665) left over from an earlier icon revision, while the bubble body path attaches the tail at y=672. The 7px mismatch made librsvg/Cairo (used by generate.sh) paint a visible white line across every rasterized icon (dock, taskbar, PWA, favicon). The live login screen was unaffected since AppIconMark.tsx renders in the browser and doesn't include that overlay layer. Corrected bubbleClip to match the real path, then regenerated the full icon set via generate.sh.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #910's underlying icon-generation bug: the shipped app icon (dock, taskbar, PWA, favicon) has a visible white line where the chat-bubble tail meets its body.
Root cause:
bubbleClip(the clip-path gating the glass-highlight overlay inicon-source.svg/icon-source-maskable.svg) used a stale tail coordinate (y=665) left over from an earlier icon revision, while the bubble body path actually attaches the tail aty=672. The 7px mismatch made librsvg/Cairo (used bygenerate.sh) paint a visible seam in every rasterized icon. The live login screen was never affected —AppIconMark.tsxrenders in the browser and doesn't include that overlay layer.Fix: corrected
bubbleClipto match the real path, then regenerated the full icon set viagenerate.sh(58 derived assets).Verified pixel-identical between a from-scratch
generate.shrun and the committed output before and after the fix.