Update BUILDING.md to include libevent-dev#43252
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the Linux build prerequisites documentation to reflect the new ot-commissioner dependency (introduced for Thread MeshCoP commissioning) that links against system libevent libraries on Debian/Ubuntu.
Changes:
- Add
libevent-devto the Debian/Ubuntuapt-get installprerequisites list indocs/guides/BUILDING.md.
There was a problem hiding this comment.
Code Review
The pull request updates the BUILDING.md documentation to include libevent-dev in the apt-get install command for Linux prerequisites. This change addresses a linking issue for ot-commissioner on fresh Linux builds. The change is a straightforward documentation update and directly resolves the reported issue. The existing comment is valid and aligns with good documentation practices, so it has been kept.
|
PR #43252: Size comparison from 7f6dd32 to 2ccf1d4 Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #43252 +/- ##
=======================================
Coverage 53.73% 53.73%
=======================================
Files 1530 1530
Lines 105861 105861
Branches 13312 13312
=======================================
Hits 56884 56884
Misses 48977 48977 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary
ot-commissioner introduced via PR #43029 for Thread MeshCoP commissioning links against system libevent libraries (libevent_core, libevent_pthreads) on Linux. But docs/guides/BUILDING.md does not list libevent-dev in the “Installing prerequisites on Linux” apt-get command.
This mismatch causes fresh local linux builds of chip-tool / Python controller (and other controller targets) to fail at link time.
Related issues
#43198
Testing
Documentation-only change (no functional code changes). Adding it to the Linux prerequisites aligns local developer setup prerequisites.