fix(session_card): CI-safe headless chrome flags - #13
Merged
Merged
Conversation
The chrome render on GitHub runners intermittently times out after 20s (first observed on run 33490519437, main, post-merge of the corpus-verify restore). Root cause is environmental, not the merged change: stock headless chrome on a root CI container needs --no-sandbox (sandbox refuses to start as root), --disable-dev-shm-usage (/dev/shm is tiny in containers), and an isolated --user-data-dir (first-run/new-profile waits). Without these the renderer can hang until the 20s cap. Flags added: --no-sandbox, --disable-dev-shm-usage, --disable-extensions, --no-first-run, --no-default-browser-check, --disable-crash-reporter, --user-data-dir=<tmp>. Behavior on desktops is unchanged (same screenshot path, same virtual-time budget).
…imeout Even with CI-safe flags the 3.12 leg intermittently still hits the 20s cap (run 33499015053) while other legs and reruns pass - the render is flaky under runner load, not broken. On timeout, retry once with a 60s window before giving up; real failures (non-zero exit, empty screenshot) still surface immediately with their own reasons.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the corpus-verify restore already on main.
Main's post-merge CI failed on
tests/test_session_card.py::test_render_card_chrome_produces_png(chrome render timed out after 20s) — run 33490519437, python 3.12 leg only; the 3.11 leg and the same test on the PR run passed. Root cause is environmental: stock headless Chrome as root in a CI container needs--no-sandbox,--disable-dev-shm-usage, and an isolated--user-data-dir, otherwise the renderer can hang until the timeout. The rerun of that leg passed (flake confirmed).This patch adds those flags plus first-run suppressors, with no behavior change on desktops (same screenshot path, same virtual-time budget).