Pass one NDM to backend init#10528
Merged
Merged
Conversation
Take external NDM if it exists, otherwise internal. Note: by default, xnnpack uses the named_data_map. Constants are not stored with the delegated blob anymore. Differential Revision: [D73679710](https://our.internmc.facebook.com/intern/diff/D73679710/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10528
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 5a5bac5 with merge base 4524838 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
lucylq
added a commit
that referenced
this pull request
Apr 28, 2025
Take external NDM if it exists, otherwise internal. Note: by default, xnnpack uses the named_data_map. Constants are not stored with the delegated blob anymore. Differential Revision: [D73679710](https://our.internmc.facebook.com/intern/diff/D73679710/) ghstack-source-id: 280710106 Pull Request resolved: #10528
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D73679710 |
JacobSzwejbka
requested changes
Apr 28, 2025
This was referenced Apr 28, 2025
Take external NDM if it exists, otherwise internal. Note: by default, xnnpack uses the named_data_map. Constants are not stored with the delegated blob anymore. Differential Revision: [D73679710](https://our.internmc.facebook.com/intern/diff/D73679710/) [ghstack-poisoned]
lucylq
added a commit
that referenced
this pull request
Apr 28, 2025
Pull Request resolved: #10528 Take external NDM if it exists, otherwise internal. Note: by default, xnnpack uses the named_data_map. Constants are not stored with the delegated blob anymore. ghstack-source-id: 280808267 Differential Revision: [D73679710](https://our.internmc.facebook.com/intern/diff/D73679710/)
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D73679710 |
Take external NDM if it exists, otherwise internal. Note: by default, xnnpack uses the named_data_map. Constants are not stored with the delegated blob anymore. Differential Revision: [D73679710](https://our.internmc.facebook.com/intern/diff/D73679710/) [ghstack-poisoned]
lucylq
added a commit
that referenced
this pull request
Apr 29, 2025
Pull Request resolved: #10528 Take external NDM if it exists, otherwise internal. Note: by default, xnnpack uses the named_data_map. Constants are not stored with the delegated blob anymore. ghstack-source-id: 281044605 Differential Revision: [D73679710](https://our.internmc.facebook.com/intern/diff/D73679710/)
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D73679710 |
Take external NDM if it exists, otherwise internal. Note: by default, xnnpack uses the named_data_map. Constants are not stored with the delegated blob anymore. Differential Revision: [D73679710](https://our.internmc.facebook.com/intern/diff/D73679710/) [ghstack-poisoned]
lucylq
added a commit
that referenced
this pull request
Apr 30, 2025
Pull Request resolved: #10528 Take external NDM if it exists, otherwise internal. Note: by default, xnnpack uses the named_data_map. Constants are not stored with the delegated blob anymore. ghstack-source-id: 281074087 Differential Revision: [D73679710](https://our.internmc.facebook.com/intern/diff/D73679710/)
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D73679710 |
Take external NDM if it exists, otherwise internal. Note: by default, xnnpack uses the named_data_map. Constants are not stored with the delegated blob anymore. Differential Revision: [D73679710](https://our.internmc.facebook.com/intern/diff/D73679710/) [ghstack-poisoned]
lucylq
added a commit
that referenced
this pull request
Apr 30, 2025
Pull Request resolved: #10528 Take external NDM if it exists, otherwise internal. Note: by default, xnnpack uses the named_data_map. Constants are not stored with the delegated blob anymore. ghstack-source-id: 281074087 Differential Revision: [D73679710](https://our.internmc.facebook.com/intern/diff/D73679710/)
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D73679710 |
Take external NDM if it exists, otherwise internal. Note: by default, xnnpack uses the named_data_map. Constants are not stored with the delegated blob anymore. Differential Revision: [D73679710](https://our.internmc.facebook.com/intern/diff/D73679710/) [ghstack-poisoned]
lucylq
added a commit
that referenced
this pull request
Apr 30, 2025
Pull Request resolved: #10528 Take external NDM if it exists, otherwise internal. Note: by default, xnnpack uses the named_data_map. Constants are not stored with the delegated blob anymore. ghstack-source-id: 281201577 Differential Revision: [D73679710](https://our.internmc.facebook.com/intern/diff/D73679710/)
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D73679710 |
Take external NDM if it exists, otherwise internal. Note: by default, xnnpack uses the named_data_map. Constants are not stored with the delegated blob anymore. Differential Revision: [D73679710](https://our.internmc.facebook.com/intern/diff/D73679710/) [ghstack-poisoned]
lucylq
added a commit
that referenced
this pull request
Apr 30, 2025
Pull Request resolved: #10528 Take external NDM if it exists, otherwise internal. Note: by default, xnnpack uses the named_data_map. Constants are not stored with the delegated blob anymore. ghstack-source-id: 281215638 Differential Revision: [D73679710](https://our.internmc.facebook.com/intern/diff/D73679710/)
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D73679710 |
Take external NDM if it exists, otherwise internal. Note: by default, xnnpack uses the named_data_map. Constants are not stored with the delegated blob anymore. Differential Revision: [D73679710](https://our.internmc.facebook.com/intern/diff/D73679710/) [ghstack-poisoned]
lucylq
added a commit
that referenced
this pull request
Apr 30, 2025
Pull Request resolved: #10528 Take external NDM if it exists, otherwise internal. Note: by default, xnnpack uses the named_data_map. Constants are not stored with the delegated blob anymore. ghstack-source-id: 281215638 Differential Revision: [D73679710](https://our.internmc.facebook.com/intern/diff/D73679710/)
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D73679710 |
mcr229
approved these changes
May 2, 2025
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Take external NDM if it exists, otherwise internal.
Note: by default, xnnpack uses the named_data_map. Constants are not stored with the delegated blob anymore.
Differential Revision: D73679710