Rename ModuleLinear -> ModuleAddMul#10529
Merged
Merged
Conversation
In export_program, the `ModuleLinear` is a decomposed add mul. Renaming it to addmul, so that we can add a ModuleLinear that calls nn.Linear for backend program-data separation testing. Differential Revision: [D73679750](https://our.internmc.facebook.com/intern/diff/D73679750/) [ghstack-poisoned]
lucylq
requested review from
JacobSzwejbka,
kirklandsign,
larryliu0820 and
swolchok
as code owners
This was referenced Apr 28, 2025
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10529
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 6dd40f2 with merge base cd3b53d ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
lucylq
added a commit
that referenced
this pull request
Apr 28, 2025
In export_program, the `ModuleLinear` is a decomposed add mul. Renaming it to addmul, so that we can add a ModuleLinear that calls nn.Linear for backend program-data separation testing. Differential Revision: [D73679750](https://our.internmc.facebook.com/intern/diff/D73679750/) ghstack-source-id: 280754574 Pull Request resolved: #10529
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D73679750 |
This was referenced Apr 28, 2025
JacobSzwejbka
approved these changes
May 2, 2025
In export_program, the `ModuleLinear` is a decomposed add mul. Renaming it to addmul, so that we can add a ModuleLinear that calls nn.Linear for backend program-data separation testing. Differential Revision: [D73679750](https://our.internmc.facebook.com/intern/diff/D73679750/) [ghstack-poisoned]
lucylq
added a commit
that referenced
this pull request
May 3, 2025
Pull Request resolved: #10529 In export_program, the `ModuleLinear` is a decomposed add mul. Renaming it to addmul, so that we can add a ModuleLinear that calls nn.Linear for backend program-data separation testing. ghstack-source-id: 281796261 Differential Revision: [D73679750](https://our.internmc.facebook.com/intern/diff/D73679750/)
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D73679750 |
In export_program, the `ModuleLinear` is a decomposed add mul. Renaming it to addmul, so that we can add a ModuleLinear that calls nn.Linear for backend program-data separation testing. Differential Revision: [D73679750](https://our.internmc.facebook.com/intern/diff/D73679750/) [ghstack-poisoned]
lucylq
added a commit
that referenced
this pull request
May 5, 2025
Pull Request resolved: #10529 In export_program, the `ModuleLinear` is a decomposed add mul. Renaming it to addmul, so that we can add a ModuleLinear that calls nn.Linear for backend program-data separation testing. ghstack-source-id: 282071040 Differential Revision: [D73679750](https://our.internmc.facebook.com/intern/diff/D73679750/)
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D73679750 |
In export_program, the `ModuleLinear` is a decomposed add mul. Renaming it to addmul, so that we can add a ModuleLinear that calls nn.Linear for backend program-data separation testing. Differential Revision: [D73679750](https://our.internmc.facebook.com/intern/diff/D73679750/) [ghstack-poisoned]
lucylq
added a commit
that referenced
this pull request
May 5, 2025
Pull Request resolved: #10529 In export_program, the `ModuleLinear` is a decomposed add mul. Renaming it to addmul, so that we can add a ModuleLinear that calls nn.Linear for backend program-data separation testing. ghstack-source-id: 282101505 Differential Revision: [D73679750](https://our.internmc.facebook.com/intern/diff/D73679750/)
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D73679750 |
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
guangy10
pushed a commit
that referenced
this pull request
May 5, 2025
This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #10529 by @lucylq ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/lucylq/70/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/lucylq/70/head Merge bot PR base: https://github.com/pytorch/executorch/tree/main Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/lucylq/70/orig @diff-train-skip-merge Co-authored-by: lucylq <lfq@meta.com>
phaiting
pushed a commit
that referenced
this pull request
May 6, 2025
This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #10529 by @lucylq ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/lucylq/70/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/lucylq/70/head Merge bot PR base: https://github.com/pytorch/executorch/tree/main Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/lucylq/70/orig @diff-train-skip-merge Co-authored-by: lucylq <lfq@meta.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
In export_program, the
ModuleLinearis a decomposed add mul. Renaming it to addmul, so that we can add a ModuleLinear that calls nn.Linear for backend program-data separation testing.Differential Revision: D73679750