Convert args to LlmConfig#11081

Merged

facebook-github-bot merged 19 commits into

gh/jackzhxng/12/basefrom

gh/jackzhxng/12/head

Jun 10, 2025

jackzhxng commented May 22, 2025 •

edited

Loading

Contributor

Stack from ghstack (oldest at bottom):

Differential Revision: D75263990


          Convert args to LlmConfig

aed7c50

[ghstack-poisoned]

jackzhxng requested a review from lucylq as a code owner

May 22, 2025 22:36

This was referenced May 22, 2025

Add new export LLM config #11028

Merged

Introduce hydra framework with backwards compatibility #11029

Merged

pytorch-bot Bot commented May 22, 2025 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11081

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit c5b956c with merge base c2aa614 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot added the CLA Signed label

jackzhxng added a commit that referenced this pull request


          Convert args to LlmConfig

b02cdce

ghstack-source-id: f219b29
Pull Request resolved: #11081

jackzhxng mentioned this pull request

Use llm_config instead of args in export_llama functions #11084

Closed

jackzhxng added 2 commits

May 22, 2025 17:39


          Update on "Convert args to LlmConfig"

749f3a5

[ghstack-poisoned]


          Update on "Convert args to LlmConfig"

65aa3b0

[ghstack-poisoned]

jackzhxng added the release notes: none label

jackzhxng commented May 23, 2025

Contributor Author

@jackzhxng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

1 similar comment

jackzhxng commented May 27, 2025

Contributor Author

@jackzhxng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

jackzhxng mentioned this pull request

Use llm_config instead of args in export_llama functions #11162

Merged

jackzhxng commented May 27, 2025

Contributor Author

@jackzhxng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.


          Update on "Convert args to LlmConfig"

8acf68f

Differential Revision: [D75263990](https://our.internmc.facebook.com/intern/diff/D75263990)

[ghstack-poisoned]

jackzhxng commented May 27, 2025

Contributor Author

@jackzhxng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

This was referenced May 27, 2025

Fix test_llama #11165

Closed

refactor: Replace self.args with LlmConfig in model.py and export_llama_lib.py #11166

Closed

fix: add missing LlmConfig import and parameter in export_llama_lib.py #11167

Closed

refactor: Use LlmConfig for model parameters instead of kwargs #11168

Closed

refactor: remove backward compatibility and simplify Llama2Model configuration #11169

Closed

refactor: simplify Llama2Model constructor to take llm_config directly #11170

Closed

Completely remove args from export_llama_lib #11171

Closed

jackzhxng commented May 27, 2025

Contributor Author

@jackzhxng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

1 similar comment

jackzhxng commented May 28, 2025

Contributor Author

@jackzhxng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.


          Update on "Convert args to LlmConfig"

d230d0b

Differential Revision: [D75263990](https://our.internmc.facebook.com/intern/diff/D75263990)

[ghstack-poisoned]

jackzhxng commented May 28, 2025

Contributor Author

@jackzhxng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

jackzhxng mentioned this pull request

Reduce memory requirement on export_llama tests with no params #11175

Closed

jackzhxng commented May 28, 2025

Contributor Author

@jackzhxng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented Jun 5, 2025

Contributor

This pull request was exported from Phabricator. Differential Revision: D75263990


          Update on "Convert args to LlmConfig"

cd0d188

Differential Revision: [D75263990](https://our.internmc.facebook.com/intern/diff/D75263990)

[ghstack-poisoned]

facebook-github-bot commented Jun 5, 2025

Contributor

This pull request was exported from Phabricator. Differential Revision: D75263990


          Update on "Convert args to LlmConfig"

216e231

Differential Revision: [D75263990](https://our.internmc.facebook.com/intern/diff/D75263990)

[ghstack-poisoned]

facebook-github-bot commented Jun 5, 2025

Contributor

This pull request was exported from Phabricator. Differential Revision: D75263990

jackzhxng linked an issue

that may be closed by this pull request

[etLLM] New config system to export_llama #9449

Closed


          Update on "Convert args to LlmConfig"

5138ebc

Differential Revision: [D75263990](https://our.internmc.facebook.com/intern/diff/D75263990)

[ghstack-poisoned]

facebook-github-bot commented Jun 5, 2025

Contributor

This pull request was exported from Phabricator. Differential Revision: D75263990

larryliu0820 approved these changes

View reviewed changes


          Update on "Convert args to LlmConfig"

5462ab3

Differential Revision: [D75263990](https://our.internmc.facebook.com/intern/diff/D75263990)

[ghstack-poisoned]

facebook-github-bot commented Jun 6, 2025

Contributor

This pull request was exported from Phabricator. Differential Revision: D75263990


          Update on "Convert args to LlmConfig"

7f8f4cf

Differential Revision: [D75263990](https://our.internmc.facebook.com/intern/diff/D75263990)

[ghstack-poisoned]

facebook-github-bot commented Jun 6, 2025

Contributor

This pull request was exported from Phabricator. Differential Revision: D75263990

larryliu0820 approved these changes

View reviewed changes


          Update on "Convert args to LlmConfig"

39b59cb

Differential Revision: [D75263990](https://our.internmc.facebook.com/intern/diff/D75263990)

[ghstack-poisoned]

facebook-github-bot commented Jun 6, 2025

Contributor

This pull request was exported from Phabricator. Differential Revision: D75263990


          Update on "Convert args to LlmConfig"

0a00549

Differential Revision: [D75263990](https://our.internmc.facebook.com/intern/diff/D75263990)

[ghstack-poisoned]

jackzhxng requested a review from shoumikhin as a code owner

June 9, 2025 19:55

facebook-github-bot commented Jun 9, 2025

Contributor

This pull request was exported from Phabricator. Differential Revision: D75263990


          Update on "Convert args to LlmConfig"

c5b956c

Differential Revision: [D75263990](https://our.internmc.facebook.com/intern/diff/D75263990)

[ghstack-poisoned]

facebook-github-bot commented Jun 9, 2025

Contributor

This pull request was exported from Phabricator. Differential Revision: D75263990

facebook-github-bot merged commit a2413d4 into gh/jackzhxng/12/base

103 of 104 checks passed

facebook-github-bot deleted the gh/jackzhxng/12/head branch

June 10, 2025 03:45

facebook-github-bot temporarily deployed to cherry-pick-bot

June 10, 2025 03:45

— with

GitHub Actions Inactive

pytorchbot mentioned this pull request

Convert args to LlmConfig #11513

Merged

jackzhxng added a commit that referenced this pull request


          Convert args to LlmConfig (#11513)

954f0e9

This PR was created by the merge bot to help merge the original PR into
the main branch.
ghstack PR number: #11081 by
@jackzhxng
^ Please use this as the source of truth for the PR details, comments,
and reviews
ghstack PR base:
https://github.com/pytorch/executorch/tree/gh/jackzhxng/12/base
ghstack PR head:
https://github.com/pytorch/executorch/tree/gh/jackzhxng/12/head
Merge bot PR base:
https://github.com/pytorch/executorch/tree/gh/jackzhxng/11/orig
Merge bot PR head:
https://github.com/pytorch/executorch/tree/gh/jackzhxng/12/orig
@diff-train-skip-merge

---------

Co-authored-by: Jack Zhang <32371937+jackzhxng@users.noreply.github.com>

kimishpatel reviewed

View reviewed changes

examples/models/llama/config/llm_config.py

                       llm_config = LlmConfig()
-                      # TODO: conversion code.
+                      # BaseConfig

kimishpatel Jun 10, 2025

Contributor

we should definitely vet what of those original args are worth keeping

kedarnath03 pushed a commit to kedarnath03/executorch that referenced this pull request


          Convert args to LlmConfig

045a968

ghstack-source-id: 88021d9
Pull Request resolved: pytorch/executorch#11081

kedarnath03 pushed a commit to kedarnath03/executorch that referenced this pull request


          Convert args to LlmConfig

4839cc1

ghstack-source-id: c8ffa7f
Pull Request resolved: pytorch/executorch#11081

kedarnath03 pushed a commit to kedarnath03/executorch that referenced this pull request


          Convert args to LlmConfig

f225461

Pull Request resolved: pytorch/executorch#11081




@imported-using-ghimport

Differential Revision: [D75263990](https://our.internmc.facebook.com/intern/diff/D75263990/)
ghstack-source-id: 287798913

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed fb-exported release notes: none