Use llm_config instead of args in export_llama functions by jackzhxng · Pull Request #11162 · pytorch/executorch

jackzhxng · 2025-05-27T22:27:13Z

Stack from ghstack (oldest at bottom):

Differential Revision: D75484927

[ghstack-poisoned]

pytorch-bot · 2025-05-27T22:27:17Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11162

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 1 Unrelated Failure

As of commit 9a15088 with merge base c2aa614 ():

NEW FAILURES - The following jobs have failed:

Apple / build-demo-ios / macos-job (gh)
RuntimeError: Command bash /Users/runner/work/_temp/exec_script failed with exit code 1
trunk / test-apple-model / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 1

FLAKY - The following job failed but was likely due to flakiness present on trunk:

trunk / test-models-linux-aarch64 (mul, portable, linux.arm64.2xlarge) / linux-job (gh) (matched linux rule in flaky-rules.json)
The process '/usr/bin/git' failed with exit code 128

This comment was automatically generated by Dr. CI and updates every 15 minutes.

ghstack-source-id: fa9ed19 Pull Request resolved: #11162

jackzhxng · 2025-05-27T22:31:48Z

@jackzhxng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Differential Revision: [D75484927](https://our.internmc.facebook.com/intern/diff/D75484927) [ghstack-poisoned]

ghstack-source-id: 8da22d3 Pull Request resolved: #11162

jackzhxng · 2025-05-27T22:35:27Z

@jackzhxng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Differential Revision: [D75484927](https://our.internmc.facebook.com/intern/diff/D75484927) [ghstack-poisoned]

ghstack-source-id: fe64963 Pull Request resolved: #11162

jackzhxng · 2025-05-27T23:46:29Z

@jackzhxng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Differential Revision: [D75484927](https://our.internmc.facebook.com/intern/diff/D75484927) [ghstack-poisoned]

ghstack-source-id: e3efa97 Pull Request resolved: #11162

Differential Revision: [D75484927](https://our.internmc.facebook.com/intern/diff/D75484927) [ghstack-poisoned]

ghstack-source-id: 383d944 Pull Request resolved: #11162

jackzhxng · 2025-05-28T01:12:45Z

@jackzhxng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Differential Revision: [D75484927](https://our.internmc.facebook.com/intern/diff/D75484927) [ghstack-poisoned]

Pull Request resolved: #11162 @imported-using-ghimport Differential Revision: [D75484927](https://our.internmc.facebook.com/intern/diff/D75484927/) ghstack-source-id: 288486592

facebook-github-bot · 2025-06-05T18:56:31Z

This pull request was exported from Phabricator. Differential Revision: D75484927

larryliu0820 · 2025-06-06T20:13:40Z

        ]
        parser = build_args_parser()
        args = parser.parse_args(args)
+        llm_config = convert_args_to_llm_config(args)


Like my comment in previous PR please do LlmConfig.from_args(args)

Differential Revision: [D75484927](https://our.internmc.facebook.com/intern/diff/D75484927) [ghstack-poisoned]

Pull Request resolved: #11162 @imported-using-ghimport Differential Revision: [D75484927](https://our.internmc.facebook.com/intern/diff/D75484927/) ghstack-source-id: 288794760

facebook-github-bot · 2025-06-06T21:24:44Z

This pull request was exported from Phabricator. Differential Revision: D75484927

Differential Revision: [D75484927](https://our.internmc.facebook.com/intern/diff/D75484927) [ghstack-poisoned]

Pull Request resolved: #11162 @imported-using-ghimport Differential Revision: [D75484927](https://our.internmc.facebook.com/intern/diff/D75484927/) ghstack-source-id: 288798834

facebook-github-bot · 2025-06-06T21:40:11Z

This pull request was exported from Phabricator. Differential Revision: D75484927

Differential Revision: [D75484927](https://our.internmc.facebook.com/intern/diff/D75484927) [ghstack-poisoned]

Pull Request resolved: #11162 @imported-using-ghimport Differential Revision: [D75484927](https://our.internmc.facebook.com/intern/diff/D75484927/) ghstack-source-id: 288807822

facebook-github-bot · 2025-06-06T22:17:15Z

This pull request was exported from Phabricator. Differential Revision: D75484927

Differential Revision: [D75484927](https://our.internmc.facebook.com/intern/diff/D75484927) [ghstack-poisoned]

Pull Request resolved: #11162 @imported-using-ghimport Differential Revision: [D75484927](https://our.internmc.facebook.com/intern/diff/D75484927/) ghstack-source-id: 289208261

facebook-github-bot · 2025-06-09T19:56:13Z

This pull request was exported from Phabricator. Differential Revision: D75484927

Differential Revision: [D75484927](https://our.internmc.facebook.com/intern/diff/D75484927) [ghstack-poisoned]

Pull Request resolved: #11162 @imported-using-ghimport Differential Revision: [D75484927](https://our.internmc.facebook.com/intern/diff/D75484927/) ghstack-source-id: 289227698

facebook-github-bot · 2025-06-09T20:57:11Z

This pull request was exported from Phabricator. Differential Revision: D75484927

Differential Revision: [D75484927](https://our.internmc.facebook.com/intern/diff/D75484927) [ghstack-poisoned]

Pull Request resolved: #11162 @imported-using-ghimport Differential Revision: [D75484927](https://our.internmc.facebook.com/intern/diff/D75484927/) ghstack-source-id: 289273387

facebook-github-bot · 2025-06-09T23:22:58Z

This pull request was exported from Phabricator. Differential Revision: D75484927

@jackzhxng

This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #11162 by @jackzhxng ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/jackzhxng/14/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/jackzhxng/14/head Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/jackzhxng/12/orig Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/jackzhxng/14/orig @diff-train-skip-merge --------- Co-authored-by: Jack Zhang <32371937+jackzhxng@users.noreply.github.com>

Pull Request resolved: pytorch/executorch#11162 @imported-using-ghimport Differential Revision: [D75484927](https://our.internmc.facebook.com/intern/diff/D75484927/) ghstack-source-id: 287798909

Use llm_config instead of args in export_llama functions

f69655c

[ghstack-poisoned]

jackzhxng requested a review from lucylq as a code owner May 27, 2025 22:27

This was referenced May 27, 2025

Add new export LLM config #11028

Merged

Introduce hydra framework with backwards compatibility #11029

Merged

Convert args to LlmConfig #11081

Merged

jackzhxng added a commit that referenced this pull request May 27, 2025

Use llm_config instead of args in export_llama functions

f8bb729

ghstack-source-id: fa9ed19 Pull Request resolved: #11162

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 27, 2025

jackzhxng added the release notes: none Do not include this in the release notes label May 27, 2025

Update on "Use llm_config instead of args in export_llama functions"

d9c70c2

Differential Revision: [D75484927](https://our.internmc.facebook.com/intern/diff/D75484927) [ghstack-poisoned]

jackzhxng added a commit that referenced this pull request May 27, 2025

Use llm_config instead of args in export_llama functions

3a09118

ghstack-source-id: 8da22d3 Pull Request resolved: #11162

Update on "Use llm_config instead of args in export_llama functions"

209fd7f

Differential Revision: [D75484927](https://our.internmc.facebook.com/intern/diff/D75484927) [ghstack-poisoned]

jackzhxng added a commit that referenced this pull request May 27, 2025

Use llm_config instead of args in export_llama functions

ff15e5c

ghstack-source-id: fe64963 Pull Request resolved: #11162

jackzhxng added the ciflow/trunk label May 27, 2025

Update on "Use llm_config instead of args in export_llama functions"

45571eb

Differential Revision: [D75484927](https://our.internmc.facebook.com/intern/diff/D75484927) [ghstack-poisoned]

jackzhxng requested a review from digantdesai as a code owner May 28, 2025 00:16

jackzhxng added a commit that referenced this pull request May 28, 2025

Use llm_config instead of args in export_llama functions

fd4495b

ghstack-source-id: e3efa97 Pull Request resolved: #11162

Update on "Use llm_config instead of args in export_llama functions"

97ec69c

Differential Revision: [D75484927](https://our.internmc.facebook.com/intern/diff/D75484927) [ghstack-poisoned]

jackzhxng added a commit that referenced this pull request May 28, 2025

Use llm_config instead of args in export_llama functions

ca68941

ghstack-source-id: 383d944 Pull Request resolved: #11162

Update on "Use llm_config instead of args in export_llama functions"

792022d

Differential Revision: [D75484927](https://our.internmc.facebook.com/intern/diff/D75484927) [ghstack-poisoned]

larryliu0820 reviewed Jun 6, 2025

View reviewed changes

Comment thread examples/models/llama/config/llm_config_utils.py Outdated

Update on "Use llm_config instead of args in export_llama functions"

54477dc

Differential Revision: [D75484927](https://our.internmc.facebook.com/intern/diff/D75484927) [ghstack-poisoned]

Update on "Use llm_config instead of args in export_llama functions"

6f3e0a5

Differential Revision: [D75484927](https://our.internmc.facebook.com/intern/diff/D75484927) [ghstack-poisoned]

Update on "Use llm_config instead of args in export_llama functions"

c447cbd

Differential Revision: [D75484927](https://our.internmc.facebook.com/intern/diff/D75484927) [ghstack-poisoned]

larryliu0820 approved these changes Jun 6, 2025

View reviewed changes

Update on "Use llm_config instead of args in export_llama functions"

679fe9e

Differential Revision: [D75484927](https://our.internmc.facebook.com/intern/diff/D75484927) [ghstack-poisoned]

Update on "Use llm_config instead of args in export_llama functions"

52455bc

Differential Revision: [D75484927](https://our.internmc.facebook.com/intern/diff/D75484927) [ghstack-poisoned]

Update on "Use llm_config instead of args in export_llama functions"

9a15088

Differential Revision: [D75484927](https://our.internmc.facebook.com/intern/diff/D75484927) [ghstack-poisoned]

facebook-github-bot merged commit 27afa9c into gh/jackzhxng/14/base Jun 10, 2025
194 of 200 checks passed

facebook-github-bot deleted the gh/jackzhxng/14/head branch June 10, 2025 03:45

facebook-github-bot temporarily deployed to cherry-pick-bot June 10, 2025 03:45 — with GitHub Actions Inactive

pytorchbot mentioned this pull request Jun 10, 2025

Use llm_config instead of args in export_llama functions #11514

Merged

Conversation

jackzhxng commented May 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot Bot commented May 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11162

❌ 2 New Failures, 1 Unrelated Failure

Uh oh!

jackzhxng commented May 27, 2025

Uh oh!

jackzhxng commented May 27, 2025

Uh oh!

jackzhxng commented May 27, 2025

Uh oh!

jackzhxng commented May 28, 2025

Uh oh!

facebook-github-bot commented Jun 5, 2025

Uh oh!

larryliu0820 Jun 6, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

facebook-github-bot commented Jun 6, 2025

Uh oh!

facebook-github-bot commented Jun 6, 2025

Uh oh!

facebook-github-bot commented Jun 6, 2025

Uh oh!

facebook-github-bot commented Jun 9, 2025

Uh oh!

facebook-github-bot commented Jun 9, 2025

Uh oh!

facebook-github-bot commented Jun 9, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jackzhxng commented May 27, 2025 •

edited

Loading

pytorch-bot Bot commented May 27, 2025 •

edited

Loading