[ET] enabling half dtype output for dequantization and making logic consistent#11552
Merged
Conversation
…onsistent Enabling half dtype output and making dequantization logic consistent between per_tensor and per_token as it is currently prone to integer overflows on one over the other Differential Revision: [D76289181](https://our.internmc.facebook.com/intern/diff/D76289181/) [ghstack-poisoned]
ahmtox
requested review from
JacobSzwejbka,
lucylq,
manuelcandales and
swolchok
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11552
Note: Links to docs will display an error until the docs builds have been completed. ❌ 4 New Failures, 2 Cancelled Jobs, 18 Unrelated FailuresAs of commit 5cfc153 with merge base 8cfa858 ( NEW FAILURES - The following jobs have failed:
CANCELLED JOBS - The following jobs were cancelled. Please retry:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
This was referenced Jun 9, 2025
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76289181 |
manuelcandales
approved these changes
Jun 11, 2025
…ing logic consistent" Enabling half dtype output and making dequantization logic consistent between per_tensor and per_token as it is currently prone to integer overflows on one over the other Differential Revision: [D76289181](https://our.internmc.facebook.com/intern/diff/D76289181/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76289181 |
…ing logic consistent" Enabling half dtype output and making dequantization logic consistent between per_tensor and per_token as it is currently prone to integer overflows on one over the other Differential Revision: [D76289181](https://our.internmc.facebook.com/intern/diff/D76289181/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76289181 |
…ing logic consistent" Enabling half dtype output and making dequantization logic consistent between per_tensor and per_token as it is currently prone to integer overflows on one over the other Differential Revision: [D76289181](https://our.internmc.facebook.com/intern/diff/D76289181/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76289181 |
…ing logic consistent" Enabling half dtype output and making dequantization logic consistent between per_tensor and per_token as it is currently prone to integer overflows on one over the other Differential Revision: [D76289181](https://our.internmc.facebook.com/intern/diff/D76289181/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76289181 |
…ing logic consistent" Enabling half dtype output and making dequantization logic consistent between per_tensor and per_token as it is currently prone to integer overflows on one over the other Differential Revision: [D76289181](https://our.internmc.facebook.com/intern/diff/D76289181/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76289181 |
…ing logic consistent" Enabling half dtype output and making dequantization logic consistent between per_tensor and per_token as it is currently prone to integer overflows on one over the other Differential Revision: [D76289181](https://our.internmc.facebook.com/intern/diff/D76289181/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76289181 |
…ing logic consistent" Enabling half dtype output and making dequantization logic consistent between per_tensor and per_token as it is currently prone to integer overflows on one over the other Differential Revision: [D76289181](https://our.internmc.facebook.com/intern/diff/D76289181/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76289181 |
…ing logic consistent" Enabling half dtype output and making dequantization logic consistent between per_tensor and per_token as it is currently prone to integer overflows on one over the other Differential Revision: [D76289181](https://our.internmc.facebook.com/intern/diff/D76289181/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76289181 |
…ing logic consistent" Enabling half dtype output and making dequantization logic consistent between per_tensor and per_token as it is currently prone to integer overflows on one over the other Differential Revision: [D76289181](https://our.internmc.facebook.com/intern/diff/D76289181/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76289181 |
facebook-github-bot
merged commit 64d1f4d
into
gh/ahmtox/17/base
73 of 98 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Enabling half dtype output and making dequantization logic consistent between per_tensor and per_token as it is currently prone to integer overflows on one over the other
Differential Revision: D76289181