[ET-VK][Ops] choose_qparams op shaders and impl#11557
Merged
Merged
Conversation
Creating the choose_qparams per_tensor and per_token logic shaders and impl which are linked with the testing framework Differential Revision: [D76436933](https://our.internmc.facebook.com/intern/diff/D76436933/) [ghstack-poisoned]
This was referenced Jun 9, 2025
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11557
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit fb32aa6 with merge base 3b1c7fd ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Jun 11, 2025
ahmtox
pushed a commit
that referenced
this pull request
Jun 11, 2025
Creating the choose_qparams per_tensor and per_token logic shaders and impl which are linked with the testing framework Differential Revision: [D76436933](https://our.internmc.facebook.com/intern/diff/D76436933/) ghstack-source-id: 289707213 Pull Request resolved: #11557
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76436933 |
Creating the choose_qparams per_tensor and per_token logic shaders and impl which are linked with the testing framework Differential Revision: [D76436933](https://our.internmc.facebook.com/intern/diff/D76436933/) [ghstack-poisoned]
ahmtox
pushed a commit
that referenced
this pull request
Jun 11, 2025
Pull Request resolved: #11557 Creating the choose_qparams per_tensor and per_token logic shaders and impl which are linked with the testing framework ghstack-source-id: 289710869 @exported-using-ghexport Differential Revision: [D76436933](https://our.internmc.facebook.com/intern/diff/D76436933/)
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76436933 |
Creating the choose_qparams per_tensor and per_token logic shaders and impl which are linked with the testing framework Differential Revision: [D76436933](https://our.internmc.facebook.com/intern/diff/D76436933/) [ghstack-poisoned]
ahmtox
pushed a commit
that referenced
this pull request
Jun 11, 2025
Pull Request resolved: #11557 Creating the choose_qparams per_tensor and per_token logic shaders and impl which are linked with the testing framework ghstack-source-id: 289745868 @exported-using-ghexport Differential Revision: [D76436933](https://our.internmc.facebook.com/intern/diff/D76436933/)
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76436933 |
Creating the choose_qparams per_tensor and per_token logic shaders and impl which are linked with the testing framework Differential Revision: [D76436933](https://our.internmc.facebook.com/intern/diff/D76436933/) [ghstack-poisoned]
Creating the choose_qparams per_tensor and per_token logic shaders and impl which are linked with the testing framework Differential Revision: [D76436933](https://our.internmc.facebook.com/intern/diff/D76436933/) [ghstack-poisoned]
ahmtox
pushed a commit
that referenced
this pull request
Jun 12, 2025
Pull Request resolved: #11557 Creating the choose_qparams per_tensor and per_token logic shaders and impl which are linked with the testing framework ghstack-source-id: 289798630 @exported-using-ghexport Differential Revision: [D76436933](https://our.internmc.facebook.com/intern/diff/D76436933/)
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76436933 |
Creating the choose_qparams per_tensor and per_token logic shaders and impl which are linked with the testing framework Differential Revision: [D76436933](https://our.internmc.facebook.com/intern/diff/D76436933/) [ghstack-poisoned]
ahmtox
pushed a commit
that referenced
this pull request
Jun 12, 2025
Pull Request resolved: #11557 Creating the choose_qparams per_tensor and per_token logic shaders and impl which are linked with the testing framework ghstack-source-id: 289992011 @exported-using-ghexport Differential Revision: [D76436933](https://our.internmc.facebook.com/intern/diff/D76436933/)
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76436933 |
Creating the choose_qparams per_tensor and per_token logic shaders and impl which are linked with the testing framework Differential Revision: [D76436933](https://our.internmc.facebook.com/intern/diff/D76436933/) [ghstack-poisoned]
ahmtox
pushed a commit
that referenced
this pull request
Jun 12, 2025
Pull Request resolved: #11557 Creating the choose_qparams per_tensor and per_token logic shaders and impl which are linked with the testing framework ghstack-source-id: 289993349 @exported-using-ghexport Differential Revision: [D76436933](https://our.internmc.facebook.com/intern/diff/D76436933/)
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76436933 |
Creating the choose_qparams per_tensor and per_token logic shaders and impl which are linked with the testing framework Differential Revision: [D76436933](https://our.internmc.facebook.com/intern/diff/D76436933/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76436933 |
Creating the choose_qparams per_tensor and per_token logic shaders and impl which are linked with the testing framework Differential Revision: [D76436933](https://our.internmc.facebook.com/intern/diff/D76436933/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76436933 |
Creating the choose_qparams per_tensor and per_token logic shaders and impl which are linked with the testing framework Differential Revision: [D76436933](https://our.internmc.facebook.com/intern/diff/D76436933/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76436933 |
Creating the choose_qparams per_tensor and per_token logic shaders and impl which are linked with the testing framework Differential Revision: [D76436933](https://our.internmc.facebook.com/intern/diff/D76436933/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76436933 |
Creating the choose_qparams per_tensor and per_token logic shaders and impl which are linked with the testing framework Differential Revision: [D76436933](https://our.internmc.facebook.com/intern/diff/D76436933/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76436933 |
Creating the choose_qparams per_tensor and per_token logic shaders and impl which are linked with the testing framework Differential Revision: [D76436933](https://our.internmc.facebook.com/intern/diff/D76436933/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76436933 |
Creating the choose_qparams per_tensor and per_token logic shaders and impl which are linked with the testing framework Differential Revision: [D76436933](https://our.internmc.facebook.com/intern/diff/D76436933/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76436933 |
SS-JIA
approved these changes
Jun 17, 2025
Creating the choose_qparams per_tensor and per_token logic shaders and impl which are linked with the testing framework Differential Revision: [D76436933](https://our.internmc.facebook.com/intern/diff/D76436933/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76436933 |
facebook-github-bot
merged commit 34816ac
into
gh/ahmtox/22/base
96 of 98 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Creating the choose_qparams per_tensor and per_token logic shaders and impl which are linked with the testing framework
Differential Revision: D76436933