[ET-VK][ez] enabling fp64->fp32 converison for vulkan compatibility#12201
Merged
Conversation
# Context We need this conversion so that certain operators can handle floating point values that need to be 64bit. This is predominantly applicable to choose_qparams.tensor where it expects a 64bit output. # Changes Simply adding an additional conversion for float64 to vulkan fp32. Differential Revision: [D77746137](https://our.internmc.facebook.com/intern/diff/D77746137/) [ghstack-poisoned]
pytorch-bot
Bot
added
the
module: vulkan
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12201
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit 4f7c0c7 with merge base 1540659 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
This was referenced Jul 3, 2025
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77746137 |
This PR needs a
|
…atibility" # Context We need this conversion so that certain operators can handle floating point values that need to be 64bit. This is predominantly applicable to choose_qparams.tensor where it expects a 64bit output. # Changes Simply adding an additional conversion for float64 to vulkan fp32. Differential Revision: [D77746137](https://our.internmc.facebook.com/intern/diff/D77746137/) cc SS-JIA manuelcandales cbilgin [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77746137 |
SS-JIA
approved these changes
Jul 7, 2025
…atibility" # Context We need this conversion so that certain operators can handle floating point values that need to be 64bit. This is predominantly applicable to choose_qparams.tensor where it expects a 64bit output. # Changes Simply adding an additional conversion for float64 to vulkan fp32. Differential Revision: [D77746137](https://our.internmc.facebook.com/intern/diff/D77746137/) cc SS-JIA manuelcandales cbilgin [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77746137 |
SS-JIA
approved these changes
Jul 11, 2025
…atibility" # Context We need this conversion so that certain operators can handle floating point values that need to be 64bit. This is predominantly applicable to choose_qparams.tensor where it expects a 64bit output. # Changes Simply adding an additional conversion for float64 to vulkan fp32. Differential Revision: [D77746137](https://our.internmc.facebook.com/intern/diff/D77746137/) cc SS-JIA manuelcandales cbilgin [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77746137 |
…atibility" # Context We need this conversion so that certain operators can handle floating point values that need to be 64bit. This is predominantly applicable to choose_qparams.tensor where it expects a 64bit output. # Changes Simply adding an additional conversion for float64 to vulkan fp32. Differential Revision: [D77746137](https://our.internmc.facebook.com/intern/diff/D77746137/) cc SS-JIA manuelcandales cbilgin [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77746137 |
…atibility" # Context We need this conversion so that certain operators can handle floating point values that need to be 64bit. This is predominantly applicable to choose_qparams.tensor where it expects a 64bit output. # Changes Simply adding an additional conversion for float64 to vulkan fp32. Differential Revision: [D77746137](https://our.internmc.facebook.com/intern/diff/D77746137/) cc SS-JIA manuelcandales cbilgin [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77746137 |
…atibility" # Context We need this conversion so that certain operators can handle floating point values that need to be 64bit. This is predominantly applicable to choose_qparams.tensor where it expects a 64bit output. # Changes Simply adding an additional conversion for float64 to vulkan fp32. Differential Revision: [D77746137](https://our.internmc.facebook.com/intern/diff/D77746137/) cc SS-JIA manuelcandales cbilgin [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77746137 |
facebook-github-bot
merged commit 749ced7
into
gh/ahmtox/29/base
96 of 100 checks passed
facebook-github-bot
had a problem deploying
to
cherry-pick-bot
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Context
We need this conversion so that certain operators can handle floating point values that need to be 64bit. This is predominantly applicable to choose_qparams.tensor where it expects a 64bit output.
Changes
Simply adding an additional conversion for float64 to vulkan fp32.
Differential Revision: D77746137
cc @SS-JIA @manuelcandales @cbilgin