[ET-VK][Ops] dequantize_per_tensor.tensor variant#12209

Merged

facebook-github-bot merged 10 commits into

gh/ahmtox/37/basefrom

gh/ahmtox/37/head

Jul 14, 2025

ahmtox commented Jul 3, 2025 •

edited

Loading

Contributor

Stack from ghstack (oldest at bottom):

Context

We need a tensor variant for dequantize/quantize operators since that is the expected output of choose_qparams.

Changes

This extends the logic that currently exists to support a tensor variant for scales and zeros.

Differential Revision: D77746135


          [ET-VK][Ops] dequantize_per_tensor.tensor variant

10512c5

# Context

We need a tensor variant for dequantize/quantize operators since that is the expected output of choose_qparams.

# Changes

This extends the logic that currently exists to support a tensor variant for scales and zeros.

Differential Revision: [D77746135](https://our.internmc.facebook.com/intern/diff/D77746135/)

[ghstack-poisoned]

ahmtox requested a review from SS-JIA as a code owner

July 3, 2025 18:17

pytorch-bot Bot commented Jul 3, 2025 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12209

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 96c1a96 with merge base 1540659 ():

NEW FAILURE - The following job has failed:

pull / test-eval_llama-mmlu-linux / linux-job (gh)
RuntimeError: Command docker exec -t 5fff9cd31a9d3de3c742b498cb7ae30f0ea57b5e5776df0187916115592ee112 /exec failed with exit code 1

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Jul 3, 2025

[ET-VK][Ops] aligning Q/DQ/CQP op inputs with ATen impl #12199

Merged

[ET-VK][ez][Ops] registering Q/DQ/CQP ops and specifying optimal storage #12200

Merged

[ET-VK][ez] enabling fp64->fp32 converison for vulkan compatibility #12201

Merged

[ET-VK] lowering ExecuTorch tensor dtype for Vulkan tensor dtype to enable 64bit #12202

Closed

[ET] correcting cpu ref quantize_per_channel logic to align with ATen #12203

Merged

[ET-VK][Ops] quantize_per_channel reference impl and testing #12204

Merged

[ET-VK][Ops] quantize_per_channel shaders and impl #12205

Merged

[ET-VK][Ops] dequantize_per_channel reference impl and testing #12206

Merged

[ET-VK][Ops] dequantize_per_channel shaders and impl #12207

Merged

[ET-VK][Ops] quantize_per_tensor.tensor variant #12208

Merged

[ET-VK][testing] Q/DQ/CQP op comprehensive delegate dynamic quantization testing #12210

Merged

github-actions Bot commented Jul 3, 2025

This PR needs a `release notes:` label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

facebook-github-bot added the CLA Signed label

facebook-github-bot commented Jul 3, 2025

Contributor

This pull request was exported from Phabricator. Differential Revision: D77746135


          Update on "[ET-VK][Ops] dequantize_per_tensor.tensor variant"

83b10f7

# Context

We need a tensor variant for dequantize/quantize operators since that is the expected output of choose_qparams.

# Changes

This extends the logic that currently exists to support a tensor variant for scales and zeros.

Differential Revision: [D77746135](https://our.internmc.facebook.com/intern/diff/D77746135/)

[ghstack-poisoned]

facebook-github-bot commented Jul 3, 2025

Contributor

This pull request was exported from Phabricator. Differential Revision: D77746135

facebook-github-bot added the fb-exported label


          Update on "[ET-VK][Ops] dequantize_per_tensor.tensor variant"

32833a6

# Context

We need a tensor variant for dequantize/quantize operators since that is the expected output of choose_qparams.

# Changes

This extends the logic that currently exists to support a tensor variant for scales and zeros.

Differential Revision: [D77746135](https://our.internmc.facebook.com/intern/diff/D77746135/)

[ghstack-poisoned]

facebook-github-bot commented Jul 7, 2025

Contributor

This pull request was exported from Phabricator. Differential Revision: D77746135


          Update on "[ET-VK][Ops] dequantize_per_tensor.tensor variant"

bcd6d55

# Context

We need a tensor variant for dequantize/quantize operators since that is the expected output of choose_qparams.

# Changes

This extends the logic that currently exists to support a tensor variant for scales and zeros.

Differential Revision: [D77746135](https://our.internmc.facebook.com/intern/diff/D77746135/)

[ghstack-poisoned]

ahmtox mentioned this pull request

[ET-VK][Ops] affine quantization operators registration #12369

Merged

facebook-github-bot commented Jul 10, 2025

Contributor

This pull request was exported from Phabricator. Differential Revision: D77746135

SS-JIA approved these changes

View reviewed changes


          Update on "[ET-VK][Ops] dequantize_per_tensor.tensor variant"

d9c3310

# Context

We need a tensor variant for dequantize/quantize operators since that is the expected output of choose_qparams.

# Changes

This extends the logic that currently exists to support a tensor variant for scales and zeros.

Differential Revision: [D77746135](https://our.internmc.facebook.com/intern/diff/D77746135/)

[ghstack-poisoned]

facebook-github-bot commented Jul 11, 2025

Contributor

This pull request was exported from Phabricator. Differential Revision: D77746135


          Update on "[ET-VK][Ops] dequantize_per_tensor.tensor variant"

260376f

# Context

We need a tensor variant for dequantize/quantize operators since that is the expected output of choose_qparams.

# Changes

This extends the logic that currently exists to support a tensor variant for scales and zeros.

Differential Revision: [D77746135](https://our.internmc.facebook.com/intern/diff/D77746135/)

[ghstack-poisoned]

facebook-github-bot commented Jul 11, 2025

Contributor

This pull request was exported from Phabricator. Differential Revision: D77746135


          Update on "[ET-VK][Ops] dequantize_per_tensor.tensor variant"

87bf615

# Context

We need a tensor variant for dequantize/quantize operators since that is the expected output of choose_qparams.

# Changes

This extends the logic that currently exists to support a tensor variant for scales and zeros.

Differential Revision: [D77746135](https://our.internmc.facebook.com/intern/diff/D77746135/)

[ghstack-poisoned]

facebook-github-bot commented Jul 11, 2025

Contributor

This pull request was exported from Phabricator. Differential Revision: D77746135


          Update on "[ET-VK][Ops] dequantize_per_tensor.tensor variant"

a322267

# Context

We need a tensor variant for dequantize/quantize operators since that is the expected output of choose_qparams.

# Changes

This extends the logic that currently exists to support a tensor variant for scales and zeros.

Differential Revision: [D77746135](https://our.internmc.facebook.com/intern/diff/D77746135/)

[ghstack-poisoned]

facebook-github-bot commented Jul 11, 2025

Contributor

This pull request was exported from Phabricator. Differential Revision: D77746135


          Update on "[ET-VK][Ops] dequantize_per_tensor.tensor variant"

0990ef8

# Context

We need a tensor variant for dequantize/quantize operators since that is the expected output of choose_qparams.

# Changes

This extends the logic that currently exists to support a tensor variant for scales and zeros.

Differential Revision: [D77746135](https://our.internmc.facebook.com/intern/diff/D77746135/)

[ghstack-poisoned]

facebook-github-bot commented Jul 11, 2025

Contributor

This pull request was exported from Phabricator. Differential Revision: D77746135


          Update on "[ET-VK][Ops] dequantize_per_tensor.tensor variant"

96c1a96

# Context

We need a tensor variant for dequantize/quantize operators since that is the expected output of choose_qparams.

# Changes

This extends the logic that currently exists to support a tensor variant for scales and zeros.

Differential Revision: [D77746135](https://our.internmc.facebook.com/intern/diff/D77746135/)

[ghstack-poisoned]

facebook-github-bot commented Jul 14, 2025

Contributor

This pull request was exported from Phabricator. Differential Revision: D77746135

facebook-github-bot merged commit 8f1121b into gh/ahmtox/37/base

98 of 100 checks passed

facebook-github-bot deleted the gh/ahmtox/37/head branch

July 14, 2025 14:58

facebook-github-bot temporarily deployed to cherry-pick-bot

July 14, 2025 14:58

— with

GitHub Actions Inactive

pytorchbot mentioned this pull request

[ET-VK][Ops] dequantize_per_tensor.tensor variant #12437

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed fb-exported