Add ACTIVITIES_ENABLE_CUDA_SYNC to Kineto OD config#1247
Open
ryanzhang22 wants to merge 1 commit intopytorch:mainfrom
Open
Add ACTIVITIES_ENABLE_CUDA_SYNC to Kineto OD config#1247ryanzhang22 wants to merge 1 commit intopytorch:mainfrom
ryanzhang22 wants to merge 1 commit intopytorch:mainfrom
Conversation
Summary: We currently don't have a way to disable cuda_sync events in OD. In auto-trace, cuda_sync events are disabled by default, while they are enabled by default in OD. There is an existing ACTIVITIES_DISPLAY_CUDA_SYNC_WAIT_EVENTS option in OD, but setting this to false only disables CUPTI_ACTIVITY_SYNCHRONIZATION_TYPE_STREAM_WAIT_EVENT. To avoid changing default behavior in OD, the flag defaults to True. Differential Revision: D92274056
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
We currently don't have a way to disable cuda_sync events in OD.
In auto-trace, cuda_sync events are disabled by default, while they are enabled by default in OD. There is an existing ACTIVITIES_DISPLAY_CUDA_SYNC_WAIT_EVENTS option in OD, but setting this to false only disables CUPTI_ACTIVITY_SYNCHRONIZATION_TYPE_STREAM_WAIT_EVENT.
To avoid changing default behavior in OD, the flag defaults to True.
Differential Revision: D92274056