Skip to content

Add ACTIVITIES_ENABLE_CUDA_SYNC to Kineto OD config #1247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ryanzhang22 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add ACTIVITIES_ENABLE_CUDA_SYNC to Kineto OD config #1247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions libkineto/include/Config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,6 +236,10 @@ class Config : public AbstractConfig {
activitiesCudaSyncWaitEvents_ = enable;
}

[[nodiscard]] bool activitiesEnableCudaSyncEvents() const {
return activitiesEnableCudaSyncEvents_;
}

// Timestamp at which the profiling to start, requested by the user.
[[nodiscard]] std::chrono::time_point<std::chrono::system_clock>
requestTimestamp() const {
Expand Down Expand Up @@ -471,6 +475,7 @@ class Config : public AbstractConfig {
std::chrono::seconds activitiesWarmupDuration_;
int activitiesWarmupIterations_;
bool activitiesCudaSyncWaitEvents_;
bool activitiesEnableCudaSyncEvents_;

// Enable Profiler Config Options
// Temporarily disable shape collection until we re-roll out the feature for
Expand Down
10 changes: 10 additions & 0 deletions libkineto/src/Config.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,9 @@ constexpr char kActivitiesMaxGpuBufferSizeKey[] =
"ACTIVITIES_MAX_GPU_BUFFER_SIZE_MB";
constexpr char kActivitiesDisplayCudaSyncWaitEvents[] =
"ACTIVITIES_DISPLAY_CUDA_SYNC_WAIT_EVENTS";
// Enable all events of type CUpti_ActivitySynchronizationType.
constexpr char kActivitiesEnableCudaSyncEvents[] =
"ACTIVITIES_ENABLE_CUDA_SYNC_EVENTS";

// Client Interface
// TODO: keep supporting these older config options, deprecate in the future
Expand Down Expand Up @@ -245,6 +248,7 @@ Config::Config()
activitiesWarmupDuration_(kDefaultActivitiesWarmupDurationSecs),
activitiesWarmupIterations_(0),
activitiesCudaSyncWaitEvents_(true),
activitiesEnableCudaSyncEvents_(true),
activitiesDuration_(kDefaultActivitiesProfileDurationMSecs),
activitiesRunIterations_(0),
activitiesOnDemandTimestamp_(milliseconds(0)),
Expand Down Expand Up @@ -440,6 +444,8 @@ bool Config::handleOption(const std::string& name, std::string& val) {
activitiesWarmupIterations_ = toInt32(val);
} else if (!name.compare(kActivitiesDisplayCudaSyncWaitEvents)) {
activitiesCudaSyncWaitEvents_ = toBool(val);
} else if (!name.compare(kActivitiesEnableCudaSyncEvents)) {
activitiesEnableCudaSyncEvents_ = toBool(val);
} else if (!name.compare(kRequestTraceID)) {
requestTraceID_ = val;
} else if (!name.compare(kRequestGroupTraceID)) {
Expand Down Expand Up @@ -576,6 +582,10 @@ void Config::validate(
selectDefaultActivityTypes();
}
setActivityDependentConfig();

if (!activitiesEnableCudaSyncEvents()) {
selectedActivityTypes_.erase(ActivityType::CUDA_SYNC);
}
}

void Config::setReportPeriod(milliseconds msecs) {
Expand Down