chore: remove legacy WORKSPACE example#7
Merged
Conversation
The examples/rules_js bzlmod example already covers the supported integration path. Maintaining a parallel WORKSPACE example was breaking CI on Bazel 9 (no @npm visible because bzlmod stays on despite the local .bazelrc) and offered no coverage we don't get from the bzlmod example. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Snapshots committed on 17 May drifted ~1% of pixels on the CI runner's browser binaries. Add maxDiffPixelRatio: 0.02 so minor cross-version rendering changes don't fail the example test. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
examples/workspace/— the bzlmod example inexamples/rules_js/already covers the supported integration path.Build and Test WORKSPACE examplestep from.github/workflows/tests.yml.Why
CI on
main(and every recent PR) was failing becauseexamples/workspacewas bumped to Bazel 9.1.0, where bzlmod stays enabled despite the local.bazelrc--noenable_bzlmod --enable_workspace— so@npm(defined vianpm_translate_lockinWORKSPACE.bazel) is no longer visible andbazelisk test //...fails with "No repository visible as '@npm'".Rather than pin an older Bazel just to keep a legacy-WORKSPACE demo alive, removing the example matches actual support intent and unblocks CI.
Test plan
/examples/workspaceentries🤖 Generated with Claude Code