chore: drop Rust-era toolchains and release tooling#9
Merged
Conversation
PR #3 replaced the Rust CLI with pure Starlark, but the C/Rust build infrastructure that fed it was left in place. Nothing in the current tree consumes any of it: - toolchains_musl + tools/linkers/ existed to statically link the Linux CLI release binary against musl libc. - toolchains_llvm provided the clang/LLVM C toolchain for the same Rust build path. - tools/release/defs.bzl is now a no-op stub; the committed tools/release/artifacts/cli-* binaries (~3.3 MB) are leftover pre-built CLIs with no consumer and no rebuild path. - The build:release config in .bazelrc references @rules_rust, which was removed in PR #3. tools/platforms/ is preserved — it's still referenced from playwright/private/browser_targets.bzl at runtime by the generated Playwright repository's select() over CPU/OS. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clean up the C/Rust build infrastructure that PR #3 (Starlark spike) left orphaned.
MODULE.bazel — drop:
toolchains_muslbazel_depand itsuse_extensionblocktoolchains_llvmbazel_dep,use_extension, andregister_toolchainsblock.bazelrc — drop the
build:releaseconfig (references@rules_rustwhich is gone).Deleted directories/files:
tools/linkers/— only consumer wastoolchains_musl.config'sextra_target_compatible_withtools/release/defs.bzl—rust_binaryis now a 5-line no-op stubtools/release/copy_release_artifacts.sh— script targets a Bazel label that no longer existstools/release/artifacts/cli-{arm64,x86_64}-{apple-darwin,unknown-linux-musl}— ~3.3 MB of pre-built Rust CLIs from the pre-spike era; no longer rebuilt, no longer consumedtools/release/BUILD.bazel— only declared a filegroup of those artifactsWhat's preserved and why
tools/platforms/stays. It's referenced at runtime byplaywright/private/browser_targets.bzl:160and:185, which emitselect()s that key on@rules_playwright//tools/platforms:{linux_x86_64,linux_arm64,…}so the generated Playwright repo picks the right browser for the consumer's build configuration.Test plan
bazelisk build //...passesexamples/rules_jstest step passes (the Starlark playwright extension still resolvestools/platformsaliases correctly)rules_playwright-*.tar.gz(it's justgit archive+ stardoc — independent of the deleted infra)🤖 Generated with Claude Code