QREPO-413 add extra column to full-item-page in qulto theme and all o…#12
Merged
Conversation
…ther themes that inherit it
Add dc.* translation keys for the qulto theme i18n (hu/en) so the full-item-page label column shows localised field names. - Keys match the metadata field names (e.g. dc.title); EN reuses the official submission-form <label> texts for consistency. - Covers the 14 basic fields of the traditional submission form (traditionalpageone + traditionalpagetwo): author, title, other titles, date issued, publisher, citation, series, identifiers, type, language, subject keywords, abstract, sponsors, description.
Replace the getTranslation() component method with a reusable pipe and
fix the label column layout.
- New pure dsMetadataLabel pipe returns the localised label, or '' when
no translation exists; uses translate.stream() + async pipe so labels
react to language change without per-change-detection work.
- Drop the full constructor: with translation moved to the pipe the
component no longer needs TranslateService, so the base constructor is
inherited and the fragile DI boilerplate is removed.
- Add local SCSS (td.metadata-label { white-space: nowrap }) so two-word
labels no longer wrap when a long value cell squeezes the columns.
- Refresh the stale class JSDoc to describe the actual behaviour.
The szerep full-item-page override was behaviourally identical to qulto, so it is removed in favour of the extends chain. - Delete the szerep full-item-page component (.ts/.html); szerep now inherits qulto's version via resolveThemedComponent (extends: qulto), the same pattern already used for community-list-element/admin-sidebar. - Drop szerep i18n dc.* keys that exactly duplicate qulto's (dc.title, dc.contributor.author, dc.language.iso) plus the internal duplicate dc.title/dc.title.other; szerep keeps only labels that differ from qulto or are szerep-specific (e.g. dc.type, dc.subject, dc.date.issued, faculty/advisor/doctschool).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ther themes that inherit it
References
Add references/links to any related issues or PRs. These may include:
Description
Short summary of changes (1-2 sentences).
Instructions for Reviewers
Please add a more detailed description of the changes made by your PR. At a minimum, providing a bulleted list of changes in your PR is helpful to reviewers.
List of changes in this PR:
Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.