Refine JHO tag-notification cleanup to avoid replacement messages

[Copilot]

The JHO untagged-user follow-up was creating a replacement message when the original alert could no longer be edited. This changes the cleanup path so the temporary notification is either edited in place or deleted, without emitting a second notification.

• Notification cleanup behavior

  • Keep the in-place edit only when the alert is still the latest message in the channel.
  • Skip the edit and delete immediately when newer channel activity already makes ghost notifications irrelevant.

• Old-message fallback

  • Preserve the edit attempt for the “latest message” case.
  • If Discord rejects that edit with error 30046, delete the notification instead of sending a replacement message.
  • Continue to re-raise unrelated HTTPException cases.

The cleanup logic is implemented directly at the call site in the event flow rather than through a separate helper.

if getattr(sent_msg.channel, "last_message_id", None) == sent_msg.id:
    try:
        await sent_msg.edit(content=new_msg)
        return
    except discord.HTTPException as e:
        if e.code != 30046:
            raise

await sent_msg.delete()

[r-hensley]

@copilot I feel like the function you created is pretty simple and then the test is basically just testing basic python functionality and is pretty easy to see from the code directly that the code is fine. How necessary is a separated, helper function, and a dedicated test?

[Copilot]

@copilot I feel like the function you created is pretty simple and then the test is basically just testing basic python functionality and is pretty easy to see from the code directly that the code is ...

I agreed and simplified it in f0d03f6: the helper is gone, the logic is inlined at the call site, and I removed the helper-only test file. The remaining behavior is unchanged, and python -m pytest tests still passes.

[Copilot]

Pull request overview

Adjusts the JHO “untagged user” follow-up cleanup in cogs/events.py to avoid posting replacement notifications when the original alert can’t be edited, preferring in-place edits only when the alert is still the latest channel message and otherwise deleting the temporary notification.

Changes:

• Only attempts to edit the original notification if it is still the channel’s last_message_id.
• If the edit fails with Discord error code 30046, deletes the notification instead of sending a replacement.
• Deletes the original notification when newer channel activity exists (with best-effort delete error handling).

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.