Skip to content

Refine JHO tag-notification cleanup to avoid replacement messages #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
r-hensley merged 4 commits into from
May 23, 2026
Merged

Refine JHO tag-notification cleanup to avoid replacement messages #102

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
be25187
Add fallback for old Discord message edits
Copilot May 23, 2026
26827ec
Address review nits for message edit fallback
Copilot May 23, 2026
c906128
Adjust temporary tag notification cleanup logic
Copilot May 23, 2026
f0d03f6
Inline tag notification cleanup logic
Copilot May 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion cogs/events.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,19 @@ def on_member_update_check(m_before, m_after):
f"~~User {refreshed_author.mention} has potentially sent a message with their native "
f"language and is still untagged~~:\n"
f">>> ~~[{msg_content}](<{reaction.message.jump_url}>)~~")
await sent_msg.edit(content=new_msg)
if getattr(sent_msg.channel, "last_message_id", None) == sent_msg.id:
try:
await sent_msg.edit(content=new_msg)
return
except discord.HTTPException as e:
# Discord returns error code 30046 when a message is too old to keep editing.
if e.code != 30046:
raise
Comment thread
r-hensley marked this conversation as resolved.

try:
await sent_msg.delete()
except (discord.Forbidden, discord.NotFound, discord.HTTPException):
pass

utils.asyncio_task(check_untagged_jho_users)

Expand Down