Repository navigation
Conversation
ExoPlayer took its seek increments once, when it was built, so changing the forward or back skip in Settings only took effect after the app restarted. Follow the player settings and push changes into ExoPlayer's runtime increment setters.
Generated by 🚫 Danger Kotlin against d0b8b93 |
Collaborator
Code Coverage
|
This was referenced Oct 5, 2026
Merged
Owner
Author
r0adkll
added a commit
that referenced
this pull request
Oct 6, 2026
Found while testing #607. On Android, changing the skip forward or back time in Settings → Playback updated the player's button labels straight away, but the actual skips kept the old amounts until the app restarted. ExoPlayer took its seek increments once, from the builder, when the player was created. ## What changed - `ExoPlayerAudioPlayer` collects `observeForwardTimeMs()` and `observeBackwardTimeMs()` in its main-thread scope, and pushes changes into ExoPlayer's runtime `setSeekForwardIncrementMs` / `setSeekBackIncrementMs` (added in Media3 1.11). - That covers the in-app buttons, the media notification and other media-session controls. - Desktop and iOS already read the skip times on every skip. - A changelog entry under Fixed. ## Verification - `./scripts/ktlint --check` passes, `:app:android:compileAlphaDebugKotlin` compiles, and `:infra:audioplayer:impl:jvmTest` passes. - **On device:** the same change was verified on the emulator in the closed #1198, in one app session without restarting. Each change took effect on the next skip, whether from the in-app buttons, `cmd media_session dispatch fast-forward` / `rewind`, or the notification buttons: | Skip times (forward / back) | Result | |---|---| | 30s / 10s (unchanged) | +30s / −10s | | changed to 5s / 30s | +5s / −30s | | changed to 10s / 5s | +10s / −5s | 🤖 Generated with [Claude Code](https://claude.com/claude-code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack
Found while testing #607.
Changing the skip forward or back time in Settings → Playback updated the player's button labels straight away, but the actual skips kept the old amounts until the app restarted. The cause is that ExoPlayer took its seek increments once, from the builder, when the player was created.
mainhas the same bug.What changed
ExoPlayerAudioPlayercollectsPlayerSettingsSnapshot.forwardTimeandbackwardTimein its main-thread scope, and pushes them into ExoPlayer's runtimesetSeekForwardIncrementMs/setSeekBackIncrementMs(added in Media3 1.11).Verification
./scripts/ktlint --checkpasses, Android (alpha debug) compiles, and:infra:audioplayer:impl:jvmTestpasses.cmd media_session dispatch fast-forward/rewindThere were no crashes.
🤖 Generated with Claude Code