Skip to content

Fix ip as name#78

Merged
smcintyre-r7 merged 2 commits intomasterfrom
fix-ip-as-name
Jul 16, 2025
Merged

Fix ip as name#78
smcintyre-r7 merged 2 commits intomasterfrom
fix-ip-as-name

Conversation

@sjanusz-r7
Copy link
Contributor

Fixes #77

Test using:

bundle exec rspec

Expected output:

Finished in 0.09154 seconds (files took 0.55272 seconds to load)
165 examples, 0 failures

@pd-sonarqube-r7
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
60 Security Hotspots
0.0% Coverage on New Code (required ≥ 80%)
3.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube

@smcintyre-r7 smcintyre-r7 self-assigned this Jul 16, 2025
@smcintyre-r7 smcintyre-r7 moved this to In Progress in Metasploit Kanban Jul 16, 2025
@smcintyre-r7 smcintyre-r7 merged commit 9b35e2e into master Jul 16, 2025
41 of 42 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Metasploit Kanban Jul 16, 2025
@sjanusz-r7
Copy link
Contributor Author

Paper trail: We will need to monitor this for any issues that others might raise related to this; although RSpec tests were passing, we did encounter some related issues in code that depends on this gem in other repositories.

@sjanusz-r7 sjanusz-r7 deleted the fix-ip-as-name branch August 18, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Incorrectly classes IP address as domain name

2 participants