Skip to content

Fix ip as name #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smcintyre-r7 merged 2 commits into from
Jul 16, 2025
Merged

Fix ip as name #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29a63f3
Add ip is_name test
sjanusz-r7 Jul 15, 2025
7f3cda8
is_name? returns false if value is ip address
sjanusz-r7 Jul 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/rex/socket.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ def self.support_ipv6?
# Determine whether this is a valid DNS name without trying to resolve it
#
def self.is_name?(name)
return false if name.length > 253
return false if name.length > 253 || name =~ MATCH_IPV4 || name =~ MATCH_IPV6
name.delete_suffix('.') =~ MATCH_DNS_NAME ? (name =~ /\s/).nil? : false
end

Expand Down
7 changes: 7 additions & 0 deletions spec/rex/socket_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,6 +370,13 @@
described_class.is_name?(try)
end

context 'with an ip address' do
let(:try) { '192.168.1.1' }
it 'should return false' do
expect(name).to eq false
end
end

context 'with a hostname' do
let(:try) { "localhost" }
it "should return true" do
Expand Down