Repository navigation
Omit provider diagnostics from OAuth retry logs - #1475
Merged
Merged
Conversation
7 of 53 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redact OAuth retry diagnostics
Refs #1458 and #1442; both remain open.
Remove raw provider errors from the credential-store OAuth retry warning. Retain provider ID, operation, retry counts and delay. Retry classification, locking and credential persistence are unchanged.
The regression captures structured logs for both an Error with a token-bearing URL/cause and a non-Error transient failure. It requires retry metadata and rejects raw error/cause fields and secret sentinels.
This narrowly closes the retry-log exposure. It does not qualify every auth failure sink or change custom-provider keys, historical credentials/backups, Delegate or live accounts. No account access, inference, deployment or restart.
Validation
Focused credential-store tests: 15 pass, 56 assertions. Five typechecks, scoped lint and independent source review pass.
make ci-fastpassed 5,927 runtime tests with seven existing skips and no failures, plus 25 feature tests and nine web checks. Pack hygiene: 24,741 files. Final five types and diff checks passed against baseline4510eb5fa; unchanged compose baseline. Private Bun cache, no shared-cache permission changes.