RDKE-1066: metaChanges-donotomerge-8.5_2#90
RDKE-1066: metaChanges-donotomerge-8.5_2#90PreethiLakshmi91 wants to merge 1 commit intosupport/8.5.3.0from
Conversation
Reason for change: message_filter is using wrong list to traverse Test Procedure: Risks: Low Priority: P1 Signed-off-by: ppalan289 <preethi_palanisamy@comcast.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the BitBake machine include configuration for middleware OPKG feeds, switching the middleware artifact path to a debug feed and updating the release identifier used in those feed URLs.
Changes:
- Update
MW_IPK_PATHandMW_OSS_IPK_PATHdefaults frommiddleware-rel/...tomiddleware-dbg/.... - Change
RELEASE_NUMfrom a version string (8.5.3.0) to a ticket/build identifier (RDKE-1066_17A1).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| conf/machine/include/oss_mw.inc | Points OSS middleware feed path at middleware-dbg/${RELEASE_NUM}. |
| conf/machine/include/middleware.inc | Updates release identifier and switches primary middleware feed path to middleware-dbg/${RELEASE_NUM}. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| RELEASE_NUM = "RDKE-1066_17A1" | ||
|
|
||
| MW_IPK_PATH ?= "middleware-rel/${RELEASE_NUM}" | ||
| MW_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}" |
There was a problem hiding this comment.
The PR description mentions fixing message_filter traversal, but this diff only changes middleware IPK feed configuration (RELEASE_NUM and middleware-*/ paths). Please update the PR description (or include the missing code changes) so reviewers can validate the intended behavior and risk accurately.
| PACKAGE_EXTRA_ARCHS:append = " ${MIDDLEWARE_ARCH}" | ||
|
|
||
| RELEASE_NUM = "8.5.3.0" | ||
| RELEASE_NUM = "RDKE-1066_17A1" |
There was a problem hiding this comment.
RELEASE_NUM is now set to a ticket/build identifier ("RDKE-1066_17A1"). Because this value is embedded into the feed URL, hardcoding a non-version string here makes the config branch-specific and easy to forget to revert, which can break consumers expecting a stable release layout. Consider keeping a version-like default and/or making this value overrideable via a separate variable (e.g., a CI-provided tag) rather than committing a ticket-specific value.
| RELEASE_NUM = "RDKE-1066_17A1" | ||
|
|
||
| MW_IPK_PATH ?= "middleware-rel/${RELEASE_NUM}" | ||
| MW_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}" |
There was a problem hiding this comment.
Switching the default feed path from middleware-rel to middleware-dbg changes where OPKG will fetch middleware packages for all builds using this include. If middleware-dbg is intended only for specific debug/test builds, consider making this conditional (e.g., based on BUILD_VARIANT or an explicit feature flag) so release builds don’t unintentionally consume debug artifacts.
| MW_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}" | |
| MW_IPK_PATH ?= "${@('middleware-dbg' if d.getVar('BUILD_VARIANT') == 'dbg' else 'middleware-rel') + '/' + d.getVar('RELEASE_NUM')}" |
| PACKAGE_EXTRA_ARCHS:append = " ${MW_OSS} " | ||
| OPKG_ARCH_PRIORITY:${MW_OSS} = "205" | ||
| MW_OSS_IPK_PATH ?= "middleware-rel/${RELEASE_NUM}" | ||
| MW_OSS_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}" |
There was a problem hiding this comment.
This changes the OSS middleware feed path from middleware-rel to middleware-dbg. If middleware-dbg is not meant to be the default for all builds (including non-debug variants), consider gating this selection behind a build flag/variant to avoid pulling unintended artifacts at runtime.
| MW_OSS_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}" | |
| MW_OSS_IPK_PATH ?= "${@('middleware-dbg/%s' if (d.getVar('BUILD_VARIANT') or '').lower() in ('dbg', 'debug') else 'middleware-rel/%s') % d.getVar('RELEASE_NUM')}" |
Reason for change: message_filter is using wrong list to traverse Test Procedure:
Risks: Low
Priority: P1